tree dca6a08a57fe83663d5573c9ade8c42773919940
parent 4735254e6dbfa13048893cc43ede87a4110f4b27
author dnj <dnj@chromium.org> 1484104371 -0800
committer Commit bot <commit-bot@chromium.org> 1484104371 -0800

Annotate ErrInvalidKey.

The ErrInvalidKey error is annoying when encountered, becuase it
provides no context about why the key is invalid and can occur in some
obscure places (checkfilter, query finalization, implementations, etc.).

To address this, replace ErrInvalidKey with a test function,
IsErrInvalidKey. This will return true for any invalid key errors.
Replace instances of ErrInvalidKey with errors derived from
MakeErrInvalidKey, annotated with some context and useful information.

This should be relatively minor change upstream, since no audited code
actually checks for this error case.

BUG=None
TEST=unit

Review-Url: https://codereview.chromium.org/2620043002