| commit | c12ab6ff5cb4e6d9f78c89a172f8cc08bcdf56d5 | [log] [tgz] |
|---|---|---|
| author | dnj <dnj@chromium.org> | Tue Dec 06 17:29:01 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Tue Dec 06 17:29:01 2016 |
| tree | 5c5d365e6094043587cc1c5612fa70a8e0328b5d | |
| parent | 794153648435d6a4d6c77320da2ac10948e8800c [diff] |
impl/memory: Fix memcache stats race. Fix a race in memcache stats that was caused by modification of common stats varibles while holding a possibly-shared RLock. This fix switches locking from RWMutex to Mutex, since potentially every access contains mutations to the shared state. BUG=None TEST=local - Re-ran external test with fix, race no longer triggered. R=iannucci@chromium.org Review-Url: https://codereview.chromium.org/2554793002
designed for testing and extensibility
(but generally it should be pretty stableish).
go get -u github.com/luci/gae/...
See the godocs.
master contains the latest code.user.email and user.name are configured in git config.go get -u github.com/maruel/pre-commit-go/cmd/... && pcgRun the following to setup the code review tool and create your first review:
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" cd $GOROOT/github.com/luci/gae git new-branch work # or `git checkout -b work origin/master` if you like typing more. # hack hack git commit -a -m "This is awesome\nR=joe@example.com" # This will ask for your Google Account credentials. git cl upload -s # Wait for LGTM over email. # Check Commit Queue checkbox in Rietveld codereview site. # See it tested and landed automatically.
Use git cl help and git cl help <cmd> for more details.