| commit | c4fab9e7d5a1b17dc32257a21fde91696d6cb217 | [log] [tgz] |
|---|---|---|
| author | dnj <dnj@chromium.org> | Fri Sep 16 21:18:46 2016 |
| committer | Commit bot <commit-bot@chromium.org> | Fri Sep 16 21:18:46 2016 |
| tree | 49a9d8f86ae6f92f59ea63898ca47ef9de3a60d1 | |
| parent | 5ea8e51f703d895c9e53595d49e109c5a349a652 [diff] |
Differentiate between single- and multi- props.
Fixes #58.
Change PropertyMap to accept either a single Property or a
PropertySlice, the former being a single Property and the latter
being a multi-property regardless of content size.
This will likely break API compatibility for packages that directly use
PropertyMap, which shouldn't be too many. Updating is not difficult:
If you want to have a single property, you can assign directly instead
of wrapping in a []Property:
PropertyMap{"Foo": MkProperty("Bar")}
If you want to have a multi-valued Property, use a PropertySlice:
PropertyMap{"Foo": PropertySlice{ds.MkProperty("Bar")}}
Note that datastore now differentiates between single-valued Properties
and multi-valued Properties. When dealing with structs, luci/gae doesn't
really care when loading, but will export them as multi- if they are backed
by a slice.
BUG=None
TEST=local
Review-Url: https://codereview.chromium.org/2342063003
designed for testing and extensibility
(but generally it should be pretty stableish).
go get -u github.com/luci/gae/...
See the godocs.
master contains the latest code.user.email and user.name are configured in git config.go get -u github.com/maruel/pre-commit-go/cmd/... && pcgRun the following to setup the code review tool and create your first review:
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" cd $GOROOT/github.com/luci/gae git new-branch work # or `git checkout -b work origin/master` if you like typing more. # hack hack git commit -a -m "This is awesome\nR=joe@example.com" # This will ask for your Google Account credentials. git cl upload -s # Wait for LGTM over email. # Check Commit Queue checkbox in Rietveld codereview site. # See it tested and landed automatically.
Use git cl help and git cl help <cmd> for more details.