commit | ed72c6812cec1f9d78df1747b5356c270441ee7e | [log] [tgz] |
---|---|---|
author | Nodir Turakulov <nodir@google.com> | Thu Aug 24 23:02:11 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Aug 28 20:51:35 2017 |
tree | 39d9e9259ecd6b4fed27eaf5c2b204c6a581f931 | |
parent | e15119da16eacc91303935ec432b4c31e3dc2597 [diff] |
[taskqueue]: pass task index in callback Instead of calling the error callback in a certain order, call it with task indexes. This will simplify imlpementation of batching. R=iannucci@chromium.org Bug: Change-Id: Iacc70d14823e3223b13b49fcc9a261b61f0fb284 Reviewed-on: https://chromium-review.googlesource.com/634447 Reviewed-by: Daniel Jacques <dnj@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
designed for testing and extensibility
(but generally it should be pretty stableish).
go get -u go.chromium.org/gae/...
See the godocs.
master
contains the latest code.user.email
and user.name
are configured in git config
.go get -u github.com/maruel/pre-commit-go/cmd/... && pcg
Run the following to setup the code review tool and create your first review:
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" cd $GOROOT/github.com/luci/gae git new-branch work # or `git checkout -b work origin/master` if you like typing more. # hack hack git commit -a -m "This is awesome\nR=joe@example.com" # This will ask for your Google Account credentials. git cl upload -s # Wait for LGTM over email. # Check Commit Queue checkbox in Rietveld codereview site. # See it tested and landed automatically.
Use git cl help
and git cl help <cmd>
for more details.