| commit | 0599d2ae781317f088c8248f97bb9de38f2fc381 | [log] [tgz] |
|---|---|---|
| author | Vadim Shtayura <vadimsh@chromium.org> | Mon Feb 04 21:22:49 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Feb 04 21:22:49 2019 |
| tree | 90faa901f3b90d83380424707550ff69223ea18f | |
| parent | 4f458e7f03a67755e691904467ad65e4c91179f9 [diff] |
[lucicfg] Forbid modifying the graph as a side effect of a 'load'. All loads must be pure. We now have 'exec's specifically for dirty evaluations. This is theoretically a breaking change, but no one was relying on loads with side effects. R=tandrii@chromium.org BUG=833946 Change-Id: I3684693a8c7c0a0d6cd01dd8e3271bc34655bb00 Reviewed-on: https://chromium-review.googlesource.com/c/1451669 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
Contributing uses the same flow as Chromium contributions.