Google Git
Sign in
chromium / infra / luci / luci-go / 131c0fbbf238d32dbd2a540cfd966857ebb15fae
commit131c0fbbf238d32dbd2a540cfd966857ebb15fae[log] [tgz]
authorHaiyang Pan <hypan@google.com>Tue Apr 01 23:57:25 2025
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 01 23:57:25 2025
treef9438ef4793023e9ec51dc810bdfecf613894cc0
parent4862f1460ea313bb82817eee303605d0992992ff [diff]
[exception-db] Add ReadMask to invocations.Read & ReadBatch for ExtendedProperties

We are planning to increase the size limitation of ExtendedProperties,
from 200KB to a larger value like 2MB.
But as the "Read" function returns the entire invocation, this may cause
memory issue for batch read like 10k invocations.

This CL is to avoid this issue by introducing a new ReadMask to
conditionally return the ExtendedProperties field during read.

See https://crrev.com/c/6063979/comments/d3167cbc_69d59831 for the initial discussion.

Bug: 337058844, 40935291
Change-Id: I59270b511bd554e45b84bf5533e5ddea51ad8f37
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/6397120
Reviewed-by: Patrick Meiring <meiring@google.com>
Commit-Queue: Haiyang Pan <hypan@google.com>
21 files changed
tree: f9438ef4793023e9ec51dc810bdfecf613894cc0
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. recipes_py/
  33. resultdb/
  34. scheduler/
  35. scripts/
  36. server/
  37. source_index/
  38. standalone/
  39. starlark/
  40. swarming/
  41. teams/
  42. third_party/
  43. tokenserver/
  44. tools/
  45. tree_status/
  46. vpython/
  47. web/
  48. .gitallowed
  49. .gitignore
  50. .go-lintable
  51. AUTHORS
  52. codereview.settings
  53. CONTRIBUTING.md
  54. CONTRIBUTORS
  55. go.mod
  56. go.sum
  57. LICENSE
  58. OWNERS
  59. PRESUBMIT.py
  60. README.md
  61. staticcheck.conf
  62. tools.go
  63. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.