Google Git
Sign in
chromium / infra / luci / luci-go / 43f02b11f18a
commit43f02b11f18a447b8fae0944b0fb8711d979148d[log] [tgz]
authorVadim Shtayura <vadimsh@chromium.org>Fri May 20 23:12:21 2022
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 20 23:12:21 2022
tree24af448999a3b63d0ee8ec0d96dc37bf31b2e692
parent56ce2a2a70976db6f0ea8c228c2bb65f51592646 [diff]
[casviewer] Remove direct dependency on google.golang.org/appengine.

It appears to be the only reference to google.golang.org/appengine
from non-deprecated code in luci-go. It used appengine.VersionID,
which has a replacement in luci.Server via Options.ContainerImageID.

Deduplicate the copy-pasta of extracting version ID from
ContainerImageID while at it.

R=iannucci@chromium.org

Change-Id: I75777fc8935fd5be4fd4b24060eb338914f335a8
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3656841
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
10 files changed
tree: 24af448999a3b63d0ee8ec0d96dc37bf31b2e692
  1. appengine/
  2. auth/
  3. auth_service/
  4. build/
  5. buildbucket/
  6. casviewer/
  7. cipd/
  8. client/
  9. cmdrunner/
  10. common/
  11. config/
  12. cv/
  13. deploy/
  14. examples/
  15. gae/
  16. gce/
  17. grpc/
  18. hacks/
  19. hardcoded/
  20. led/
  21. logdog/
  22. luci_notify/
  23. lucicfg/
  24. lucictx/
  25. luciexe/
  26. machine-db/
  27. mailer/
  28. milo/
  29. mmutex/
  30. provenance/
  31. resultdb/
  32. scheduler/
  33. scripts/
  34. server/
  35. starlark/
  36. swarming/
  37. tokenserver/
  38. tools/
  39. vpython/
  40. web/
  41. .gitallowed
  42. .gitattributes
  43. .golangci.yml
  44. AUTHORS
  45. codereview.settings
  46. CONTRIBUTING.md
  47. CONTRIBUTORS
  48. go.mod
  49. go.sum
  50. LICENSE
  51. OWNERS
  52. PRESUBMIT.py
  53. README.md
  54. tools.go
  55. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoDoc

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

Contributing

Contributing uses the same flow as Chromium contributions.