blob: 2404792985c9c3befc17d8d433ef2a837551f7fb [file] [log] [blame]
// Copyright 2017 The LUCI Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package notify
import (
"context"
"testing"
buildbucketpb "go.chromium.org/luci/buildbucket/proto"
"go.chromium.org/luci/buildbucket/protoutil"
"go.chromium.org/luci/common/data/stringset"
gitpb "go.chromium.org/luci/common/proto/git"
notifypb "go.chromium.org/luci/luci_notify/api/config"
. "github.com/smartystreets/goconvey/convey"
. "go.chromium.org/luci/common/testing/assertions"
)
var (
// These defaults match up with the "basic" project config.
defaultGitilesHost = "chromium.googlesource.com"
defaultGitilesProject = "chromium/src"
// Test revisions.
rev1 = "deadbeef"
rev2 = "badcoffe"
// Test email addresses for commits.
commitEmail1 = "example1@google.com"
commitEmail2 = "example2@google.com"
// Test commits, ordered from new to old.
testCommits = []*gitpb.Commit{
{
Author: &gitpb.Commit_User{
Email: commitEmail2,
},
Id: rev2,
},
{
Author: &gitpb.Commit_User{
Email: commitEmail1,
},
Id: rev1,
},
}
revTestCommits = []*gitpb.Commit{
{
Author: &gitpb.Commit_User{
Email: commitEmail1,
},
Id: rev2,
},
{
Author: &gitpb.Commit_User{
Email: commitEmail2,
},
Id: rev1,
},
}
)
func TestCheckout(t *testing.T) {
gitilesCheckout := notifypb.GitilesCommits{
Commits: []*buildbucketpb.GitilesCommit{
{
Host: defaultGitilesHost,
Project: defaultGitilesProject,
Id: rev1,
},
{
Host: defaultGitilesHost,
Project: "third_party/hello",
Id: rev2,
},
},
}
Convey(`Conversion with GitilesCommits Empty`, t, func() {
checkout := NewCheckout(notifypb.GitilesCommits{})
So(checkout, ShouldHaveLength, 0)
result := checkout.ToGitilesCommits()
So(&result, ShouldResembleProto, &notifypb.GitilesCommits{})
})
Convey(`Conversion with GitilesCommits Non-Empty`, t, func() {
checkout := NewCheckout(gitilesCheckout)
So(checkout, ShouldResemble, Checkout{
protoutil.GitilesRepoURL(gitilesCheckout.Commits[0]): rev1,
protoutil.GitilesRepoURL(gitilesCheckout.Commits[1]): rev2,
})
result := checkout.ToGitilesCommits()
So(&result, ShouldResembleProto, &gitilesCheckout)
})
Convey(`Filter repositories from allowlist`, t, func() {
checkout := NewCheckout(gitilesCheckout)
repoURL := protoutil.GitilesRepoURL(gitilesCheckout.Commits[0])
filteredCheckout := checkout.Filter(stringset.NewFromSlice([]string{repoURL}...))
So(filteredCheckout, ShouldResemble, Checkout{repoURL: rev1})
})
}
func TestLogs(t *testing.T) {
Convey(`ComputeLogs`, t, func() {
ctx := context.Background()
history := mockHistoryFunc(map[string][]*gitpb.Commit{
"chromium/src": testCommits,
"third_party/hello": testCommits,
"third_party/what": testCommits,
})
checkout1Old := Checkout{
"https://chromium.googlesource.com/chromium/src": rev1,
"https://chromium.googlesource.com/third_party/hello": rev1,
}
checkout1New := Checkout{
"https://chromium.googlesource.com/chromium/src": rev2,
"https://chromium.googlesource.com/third_party/hello": rev2,
}
checkout2 := Checkout{
"https://chromium.googlesource.com/chromium/src": rev2,
"https://chromium.googlesource.com/third_party/what": rev2,
}
checkout3 := Checkout{
"https://chromium.googlesource.com/third_party/what": rev2,
}
Convey(`Both empty`, func() {
logs, err := ComputeLogs(ctx, "luci-proj", nil, nil, history)
So(err, ShouldBeNil)
So(logs, ShouldHaveLength, 0)
})
Convey(`One empty`, func() {
logs1, err := ComputeLogs(ctx, "luci-proj", checkout1Old, nil, history)
So(err, ShouldBeNil)
So(logs1, ShouldHaveLength, 0)
logs2, err := ComputeLogs(ctx, "luci-proj", nil, checkout1Old, history)
So(err, ShouldBeNil)
So(logs2, ShouldHaveLength, 0)
})
Convey(`Both valid, full overlap`, func() {
logs, err := ComputeLogs(ctx, "luci-proj", checkout1Old, checkout1New, history)
So(err, ShouldBeNil)
So(logs["https://chromium.googlesource.com/chromium/src"], ShouldResembleProto, testCommits[:1])
So(logs["https://chromium.googlesource.com/third_party/hello"], ShouldResembleProto, testCommits[:1])
})
Convey(`Both valid, partial overlap`, func() {
logs, err := ComputeLogs(ctx, "luci-proj", checkout1Old, checkout2, history)
So(err, ShouldBeNil)
So(logs["https://chromium.googlesource.com/chromium/src"], ShouldResembleProto, testCommits[:1])
})
Convey(`Both valid, no overlap`, func() {
logs, err := ComputeLogs(ctx, "luci-proj", checkout1Old, checkout3, history)
So(err, ShouldBeNil)
So(logs, ShouldHaveLength, 0)
})
})
testLogs := Logs{
"https://chromium.googlesource.com/chromium/src": testCommits,
"https://chromium.googlesource.com/third_party/hello": testCommits,
}
Convey(`Filter repositories from allowlist`, t, func() {
filteredLogs := testLogs.Filter(stringset.NewFromSlice([]string{
"https://chromium.googlesource.com/chromium/src",
}...))
So(filteredLogs["https://chromium.googlesource.com/chromium/src"], ShouldResembleProto, testCommits)
})
Convey(`Blamelist`, t, func() {
blamelist := testLogs.Blamelist("default")
So(blamelist, ShouldResemble, []EmailNotify{
{
Email: "example1@google.com",
Template: "default",
},
{
Email: "example2@google.com",
Template: "default",
},
})
})
}
// mockHistoryFunc returns a mock HistoryFunc that gets its history from
// a given list of gitpb.Commit.
//
// mockCommits should be ordered from newest to oldest, to mimic the ordering
// returned by Gitiles.
func mockHistoryFunc(projectCommits map[string][]*gitpb.Commit) HistoryFunc {
return func(_ context.Context, _, _, project, oldRevision, newRevision string) ([]*gitpb.Commit, error) {
mockCommits := projectCommits[project]
oldCommit := -1
newCommit := -1
for i, c := range mockCommits {
if c.Id == oldRevision {
oldCommit = i
}
if c.Id == newRevision {
newCommit = i
}
}
if oldCommit == -1 || newCommit == -1 || newCommit > oldCommit {
return nil, nil
}
commits := make([]*gitpb.Commit, oldCommit-newCommit+1)
copy(commits, mockCommits[newCommit:oldCommit+1])
return commits, nil
}
}