Google Git
Sign in
chromium / infra / luci / luci-go / 4bda5c7e56cf9d9873750c9a718d3b6187af2dde
commit4bda5c7e56cf9d9873750c9a718d3b6187af2dde[log] [tgz]
authorVadim Shtayura <vadimsh@chromium.org>Thu Feb 29 20:25:12 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 29 20:25:12 2024
tree971072dc32a5b2ecb379560ee9d25996b353260c
parenta0051c023d0474a23b6cd86e766a97d6429f316a [diff]
[swarming] Emit task's result ASAP in `collect`.

Do not buffer them all before writing them to stdout or to
the JSON output. This causes OOMs. Note that it means the
order in which we output tasks is no longer preserved
(whatever finishes first ends up in the stdout and JSON
first).

For JSON output it should not be a problem at all, since
results are represented by a dict {taskID: <result>}, which
is already unordered. For stdout, we'll see if anyone notices...
There are prons and cons.

There's a caveat: when using `-task-summary-python` legacy flag,
we need to buffer JSON results, since the order of outputs is
important in that case (it must match the order of `taskIDs`).

R=chanli@chromium.org, randymaldonado@google.com
BUG=40276579

Change-Id: I25f6724ab46c8dbda904cdd908610e1390ad312d
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5331989
Reviewed-by: Randy Maldonado <randymaldonado@google.com>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
2 files changed
tree: 971072dc32a5b2ecb379560ee9d25996b353260c
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. resultdb/
  33. scheduler/
  34. scripts/
  35. server/
  36. standalone/
  37. starlark/
  38. swarming/
  39. teams/
  40. third_party/
  41. tokenserver/
  42. tools/
  43. tree_status/
  44. vpython/
  45. web/
  46. .gitallowed
  47. .gitattributes
  48. .gitignore
  49. .go-lintable
  50. AUTHORS
  51. codereview.settings
  52. CONTRIBUTING.md
  53. CONTRIBUTORS
  54. go.mod
  55. go.sum
  56. LICENSE
  57. OWNERS
  58. PRESUBMIT.py
  59. README.md
  60. tools.go
  61. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.