commit | 5d021dff38efa18c5867e42bd90b34ea2eed6d4a | [log] [tgz] |
---|---|---|
author | Weiwei Lin <weiweilin@google.com> | Fri Jun 11 01:16:31 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 11 01:16:31 2021 |
tree | 20ebf5e15c670581e252861ece627b9c56f7f264 | |
parent | 6f5332cc555512a6818de407aa898b42f127c3a9 [diff] |
[resultui] replace build page unit tests with integration tests Build page unit tests are fragile due to increasingly complex mocking requirements. Integration tests require less mocking therefore are less likely to break. R=bryner, gavinmak@google.com Change-Id: Iac90d2c39fab4d65fd87a993901f693f1b37f997 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2951844 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Weiwei Lin <weiweilin@google.com> Auto-Submit: Weiwei Lin <weiweilin@google.com>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
Contributing uses the same flow as Chromium contributions.