commit | 6f5332cc555512a6818de407aa898b42f127c3a9 | [log] [tgz] |
---|---|---|
author | Weiwei Lin <weiweilin@google.com> | Fri Jun 11 01:05:36 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 11 01:05:36 2021 |
tree | 1b2256d30695a7c8885f2186676ec2d6aeb7b85b | |
parent | 4f55fd264009ed9f0fdf39ffb0dc973685d0c92e [diff] |
[resultui] replace inv page unit tests with integration tests Invocation page unit tests are fragile due to increasingly complex mocking requirements. Integration tests require less mocking therefore are less likely to break. Also remove not-found-page redirection test since this can not happen when the page is mounted under @vaddin/router. R=bryner, gavinmak@google.com Change-Id: Id8b4f7e4236e841b723e35a84e6a5dbee6972cf5 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2951848 Auto-Submit: Weiwei Lin <weiweilin@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Weiwei Lin <weiweilin@google.com>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
Contributing uses the same flow as Chromium contributions.