commit | 9d681cf7f70cb64a3695fd2e9e0124f352e1cf22 | [log] [tgz] |
---|---|---|
author | Vadim Shtayura <vadimsh@chromium.org> | Thu May 19 00:53:39 2022 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu May 19 00:53:39 2022 |
tree | 1d55f5ac8b1c8f68276a4e26ea77c1ecfb093fbf | |
parent | c184dcb15866c85beeff6c3e4ef561a7cd8d0383 [diff] |
[go] Favor go1.17 in "go mod tidy". It sometimes encounters conflicts that need a decision like: .../kms imports cloud.google.com/go/kms/apiv1 loaded from cloud.google.com/go/kms@v0.2.0, but go 1.16 would select v1.4.0 To upgrade to the versions selected by go 1.16: go mod tidy -go=1.16 && go mod tidy -go=1.17 If reproducibility with go 1.16 is not needed: go mod tidy -compat=1.17 Also fix stderr reference in CalledProcessError. It appears this script is executed by Python2 despite starting with "#!/usr/bin/env python3". R=ddoman@chromium.org, iannucci@chromium.org Change-Id: I07e083f585e86ae08b58c45da58718bd4bda325b Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3655015 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Yuanjun Huang <yuanjunh@google.com> Reviewed-by: Scott Lee <ddoman@chromium.org>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
Contributing uses the same flow as Chromium contributions.