| commit | b55a44dd13f1a92db138cdb0e4f5474408513a59 | [log] [tgz] |
|---|---|---|
| author | Robbie Iannucci <iannucci@chromium.org> | Thu Dec 08 16:00:08 2022 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Dec 08 16:00:08 2022 |
| tree | 6d68495a09cd0550cd7f70e20f40fb59ab508250 | |
| parent | bb21c01819ebd9788ee4034d523d0996e9af2c21 [diff] |
Revert "[Buildbucket] Validate gerrit changelist hostnames." This reverts commit bb21c01819ebd9788ee4034d523d0996e9af2c21. Reason for revert: Let's roll this back until builders produce valid data; Otherwise Buildbucket is undeployable. Original change's description: > [Buildbucket] Validate gerrit changelist hostnames. > > Stop accepting invalid gerrit changelists in builds. > This is causing problems downstream in LUCI Analysis. > > BUG=b:261350048 > TEST=Integration tests > > Change-Id: Ide0065000913509dab08be8e37fcd4f1b3ce68cd > Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/4075220 > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Patrick Meiring <meiring@google.com> Bug: b:261350048 Change-Id: Id619e48aa9b51576be6dc120115177f2a3a7bf63 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/4087520 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
It is now possible to directly install tools with go install:
go install go.chromium.org/luci/auth/client/cmd/...@latest go install go.chromium.org/luci/buildbucket/cmd/...@latest go install go.chromium.org/luci/cipd/client/cmd/...@latest go install go.chromium.org/luci/client/cmd/...@latest go install go.chromium.org/luci/cv/cmd/...@latest go install go.chromium.org/luci/gce/cmd/...@latest go install go.chromium.org/luci/grpc/cmd/...@latest go install go.chromium.org/luci/logdog/client/cmd/...@latest go install go.chromium.org/luci/luci_notify/cmd/...@latest go install go.chromium.org/luci/lucicfg/cmd/...@latest go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest go install go.chromium.org/luci/mailer/cmd/...@latest go install go.chromium.org/luci/mmutex/cmd/...@latest go install go.chromium.org/luci/resultdb/cmd/...@latest go install go.chromium.org/luci/server/cmd/...@latest go install go.chromium.org/luci/swarming/cmd/...@latest go install go.chromium.org/luci/tokenserver/cmd/...@latest go install go.chromium.org/luci/tools/cmd/...@latest
Contributing uses the same flow as Chromium contributions.