| commit | c62d6b3826b55a028de7a980f63644713835d517 | [log] [tgz] |
|---|---|---|
| author | smut <smut@google.com> | Thu Apr 25 01:18:02 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Apr 25 01:18:02 2019 |
| tree | 7cb3ea844d473f3f724cf3b7950c00f16124ae94 | |
| parent | 06db3345fe90a5ebe4908e2a793e23b8e46a29c4 [diff] |
[GCE] Add ID to CreateVM task Technically the ID is prefix + index, but not explicitly having the ID in the proto makes searching logs for all events pertaining to a specific VM ID more difficult, since CreateVM handlers are omitted unless the search is for (ID || (prefix && index)). By including ID in CreateVM, searching for ID will yield everything pertaining to the VM. Bug: 955235 Change-Id: If7269a4d37d832a9ebbf9c4723a418bb1c192252 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1582796 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: smut <smut@google.com>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
Contributing uses the same flow as Chromium contributions.