| // Copyright 2021 The LUCI Authors. |
| // |
| // Licensed under the Apache License, Version 2.0 (the "License"); |
| // you may not use this file except in compliance with the License. |
| // You may obtain a copy of the License at |
| // |
| // http://www.apache.org/licenses/LICENSE-2.0 |
| // |
| // Unless required by applicable law or agreed to in writing, software |
| // distributed under the License is distributed on an "AS IS" BASIS, |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| // See the License for the specific language governing permissions and |
| // limitations under the License. |
| |
| package migration |
| |
| import ( |
| "context" |
| "testing" |
| "time" |
| |
| "google.golang.org/protobuf/types/known/timestamppb" |
| |
| "go.chromium.org/luci/common/clock" |
| gerritpb "go.chromium.org/luci/common/proto/gerrit" |
| "go.chromium.org/luci/gae/service/datastore" |
| |
| cvbqpb "go.chromium.org/luci/cv/api/bigquery/v1" |
| migrationpb "go.chromium.org/luci/cv/api/migration" |
| "go.chromium.org/luci/cv/internal/changelist" |
| "go.chromium.org/luci/cv/internal/common" |
| "go.chromium.org/luci/cv/internal/cvtesting" |
| gf "go.chromium.org/luci/cv/internal/gerrit/gerritfake" |
| "go.chromium.org/luci/cv/internal/run" |
| |
| . "github.com/smartystreets/goconvey/convey" |
| . "go.chromium.org/luci/common/testing/assertions" |
| ) |
| |
| func TestFetchActiveRuns(t *testing.T) { |
| t.Parallel() |
| |
| Convey("FetchActiveRuns", t, func() { |
| ct := cvtesting.Test{} |
| ctx, cancel := ct.SetUp() |
| defer cancel() |
| |
| Convey("Returns migration Runs", func() { |
| const rid = "chromium/1111111111111-cafecafe" |
| updateTime := timestamppb.New(clock.Now(ctx).Add(-2 * time.Minute)) |
| ci1 := &gerritpb.ChangeInfo{ |
| Project: "infra/infra", |
| Number: 11111, |
| CurrentRevision: "deadbeef", |
| Revisions: map[string]*gerritpb.RevisionInfo{ |
| "deadbeef": { |
| Number: 7, |
| Created: timestamppb.New(updateTime.AsTime().Add(-2 * time.Minute)), |
| }, |
| }, |
| Labels: map[string]*gerritpb.LabelInfo{ |
| "Commit-Queue": { |
| All: []*gerritpb.ApprovalInfo{ |
| { |
| User: &gerritpb.AccountInfo{ |
| AccountId: 1, |
| Email: "user@example.com", |
| }, |
| Value: 1, |
| Date: timestamppb.New(updateTime.AsTime().Add(-2 * time.Minute)), |
| }, |
| }, |
| }, |
| }, |
| } |
| ci2 := &gerritpb.ChangeInfo{ |
| Project: "infra/infra", |
| Number: 11110, |
| CurrentRevision: "deadbeef", |
| Revisions: map[string]*gerritpb.RevisionInfo{ |
| "deadbeef": { |
| Number: 5, |
| Created: timestamppb.New(updateTime.AsTime().Add(-3 * time.Minute)), |
| }, |
| }, |
| Labels: map[string]*gerritpb.LabelInfo{ |
| "Commit-Queue": { |
| All: []*gerritpb.ApprovalInfo{ |
| { |
| User: &gerritpb.AccountInfo{ |
| AccountId: 1, |
| Email: "user@example.com", |
| }, |
| Value: 1, |
| Date: timestamppb.New(updateTime.AsTime().Add(-4 * time.Minute)), |
| }, |
| }, |
| }, |
| }, |
| } |
| err := datastore.Put(ctx, |
| &run.Run{ |
| ID: rid, |
| Status: run.Status_RUNNING, |
| Mode: run.DryRun, |
| CLs: common.CLIDs{1, 2}, |
| }, |
| &run.RunCL{ |
| ID: 1, |
| Run: datastore.MakeKey(ctx, run.RunKind, rid), |
| Detail: &changelist.Snapshot{ |
| ExternalUpdateTime: updateTime, |
| Deps: []*changelist.Dep{ |
| {Clid: 2, Kind: changelist.DepKind_HARD}, |
| }, |
| Patchset: 7, |
| MinEquivalentPatchset: 6, |
| Kind: &changelist.Snapshot_Gerrit{ |
| Gerrit: &changelist.Gerrit{ |
| Host: "https://chromium-review.googlesource.com/", |
| Files: []string{"1.cpp"}, |
| Info: ci1, |
| }, |
| }, |
| }, |
| Trigger: &run.Trigger{ |
| Time: timestamppb.New(updateTime.AsTime().Add(-2 * time.Minute)), |
| Mode: string(run.DryRun), |
| Email: "user@example.com", |
| GerritAccountId: 1, |
| }, |
| }, |
| &run.RunCL{ |
| ID: 2, |
| Run: datastore.MakeKey(ctx, run.RunKind, rid), |
| Detail: &changelist.Snapshot{ |
| ExternalUpdateTime: updateTime, |
| Patchset: 5, |
| MinEquivalentPatchset: 5, |
| Kind: &changelist.Snapshot_Gerrit{ |
| Gerrit: &changelist.Gerrit{ |
| Host: "https://chromium-review.googlesource.com/", |
| Files: []string{"2.cpp"}, |
| Info: ci2, |
| }, |
| }, |
| }, |
| Trigger: &run.Trigger{ |
| Time: timestamppb.New(updateTime.AsTime().Add(-3 * time.Minute)), |
| Mode: string(run.DryRun), |
| Email: "user@example.com", |
| GerritAccountId: 1, |
| }, |
| }, |
| ) |
| So(err, ShouldBeNil) |
| runs, err := fetchActiveRuns(ctx, "chromium") |
| So(err, ShouldBeNil) |
| So(runs, ShouldHaveLength, 1) |
| So(runs[0], ShouldResembleProto, &migrationpb.ActiveRun{ |
| Id: rid, |
| Cls: []*migrationpb.RunCL{ |
| { |
| Id: 1, |
| Gc: &cvbqpb.GerritChange{ |
| Host: "https://chromium-review.googlesource.com/", |
| Project: "infra/infra", |
| Change: 11111, |
| Patchset: 7, |
| EarliestEquivalentPatchset: 6, |
| Mode: cvbqpb.Mode_DRY_RUN, |
| }, |
| Files: []string{"1.cpp"}, |
| Info: ci1, |
| Trigger: &migrationpb.RunCL_Trigger{ |
| Time: timestamppb.New(updateTime.AsTime().Add(-2 * time.Minute)), |
| AccountId: 1, |
| Email: "user@example.com", |
| }, |
| Deps: []*migrationpb.RunCL_Dep{ |
| {Id: 2, Hard: true}, |
| }, |
| }, |
| { |
| Id: 2, |
| Gc: &cvbqpb.GerritChange{ |
| Host: "https://chromium-review.googlesource.com/", |
| Project: "infra/infra", |
| Change: 11110, |
| Patchset: 5, |
| EarliestEquivalentPatchset: 5, |
| Mode: cvbqpb.Mode_DRY_RUN, |
| }, |
| Files: []string{"2.cpp"}, |
| Info: ci2, |
| Trigger: &migrationpb.RunCL_Trigger{ |
| Time: timestamppb.New(updateTime.AsTime().Add(-3 * time.Minute)), |
| AccountId: 1, |
| Email: "user@example.com", |
| }, |
| }, |
| }, |
| }) |
| Convey("Excludes runs with corresponding VerifiedCQDRun entities", func() { |
| err := saveVerifiedCQDRun( |
| ctx, |
| &migrationpb.ReportVerifiedRunRequest{Run: &migrationpb.ReportedRun{ |
| Id: rid, |
| Attempt: &cvbqpb.Attempt{Key: "cafecafe"}, |
| }}, |
| func(context.Context) error { return nil }, |
| ) |
| So(err, ShouldBeNil) |
| runs, err := fetchActiveRuns(ctx, "chromium") |
| So(err, ShouldBeNil) |
| So(runs, ShouldHaveLength, 0) |
| }) |
| }) |
| Convey("Excludes non-RUNNING runs", func() { |
| err := datastore.Put(ctx, |
| &run.Run{ |
| ID: "chromium/1111111111111-deadbeef", |
| Status: run.Status_SUCCEEDED, |
| }, |
| &run.Run{ |
| ID: "chromium/2222222222222-baaaaaad", |
| Status: run.Status_FAILED, |
| }, |
| ) |
| So(err, ShouldBeNil) |
| runs, err := fetchActiveRuns(ctx, "chromium") |
| So(err, ShouldBeNil) |
| So(runs, ShouldHaveLength, 0) |
| }) |
| Convey("Excludes runs with CancelTrigger long-ops", func() { |
| err := datastore.Put(ctx, |
| &run.Run{ |
| ID: "chromium/1111111111111-deadbeef", |
| Status: run.Status_RUNNING, |
| }, |
| &run.Run{ |
| ID: "chromium/2222222222222-baaaaaad", |
| Status: run.Status_PENDING, |
| }, |
| &run.Run{ |
| ID: "chromium/1111111111111-cececece", |
| Status: run.Status_RUNNING, |
| OngoingLongOps: &run.OngoingLongOps{ |
| Ops: map[string]*run.OngoingLongOps_Op{ |
| "1-1": &run.OngoingLongOps_Op{ |
| Work: &run.OngoingLongOps_Op_CancelTriggers{}, |
| }, |
| }, |
| }, |
| }, |
| ) |
| So(err, ShouldBeNil) |
| runs, err := fetchActiveRuns(ctx, "chromium") |
| So(err, ShouldBeNil) |
| So(runs, ShouldHaveLength, 1) |
| So(runs[0].Id, ShouldEqual, "chromium/1111111111111-deadbeef") |
| }) |
| |
| Convey("Handles FYI deps", func() { |
| const rid = "chromium/1111111111111-cafecafe" |
| const gHost = "x-review.example.com" |
| |
| putCL := func(gChange int64, depCLID common.CLID, runCL bool) common.CLID { |
| triggeredAt := ct.Clock.Now().Add(-time.Minute) |
| ci := gf.CI(int(gChange), gf.CQ(+1, triggeredAt, gf.U("user-1")), gf.Updated(triggeredAt)) |
| cl := changelist.MustGobID(gHost, gChange).MustCreateIfNotExists(ctx) |
| cl.Snapshot = &changelist.Snapshot{ |
| Kind: &changelist.Snapshot_Gerrit{Gerrit: &changelist.Gerrit{ |
| Host: gHost, |
| Info: ci, |
| Files: []string{"some/file"}, |
| }}, |
| Patchset: 1, |
| MinEquivalentPatchset: 1, |
| ExternalUpdateTime: timestamppb.New(triggeredAt), |
| LuciProject: "chromium", |
| } |
| if depCLID > 0 { |
| cl.Snapshot.Deps = []*changelist.Dep{{Clid: int64(depCLID), Kind: changelist.DepKind_HARD}} |
| } |
| So(datastore.Put(ctx, cl), ShouldBeNil) |
| if runCL { |
| err := datastore.Put(ctx, &run.RunCL{ |
| ID: cl.ID, |
| Run: datastore.MakeKey(ctx, run.RunKind, rid), |
| Detail: cl.Snapshot, |
| Trigger: &run.Trigger{ |
| Time: timestamppb.New(triggeredAt), |
| Mode: string(run.DryRun), |
| Email: "user-1@example.com", |
| GerritAccountId: 1, |
| }, |
| }) |
| So(err, ShouldBeNil) |
| } |
| return cl.ID |
| } |
| depCLID := putCL(1, -1, false) |
| runCLID := putCL(2, depCLID, true) |
| So(datastore.Put(ctx, &run.Run{ |
| ID: rid, |
| Status: run.Status_RUNNING, |
| Mode: run.DryRun, |
| CLs: common.CLIDs{runCLID}, |
| }), ShouldBeNil) |
| runs, err := fetchActiveRuns(ctx, "chromium") |
| So(err, ShouldBeNil) |
| So(runs, ShouldHaveLength, 1) |
| So(runs[0].Cls, ShouldHaveLength, 1) |
| So(runs[0].Cls[0].Id, ShouldResemble, int64(runCLID)) |
| So(runs[0].FyiDeps, ShouldHaveLength, 1) |
| So(runs[0].FyiDeps[0].Id, ShouldResemble, int64(depCLID)) |
| So(runs[0].FyiDeps[0].Trigger, ShouldBeNil) |
| So(runs[0].FyiDeps[0].Deps, ShouldBeNil) |
| }) |
| }) |
| } |
