|author||Robert Iannucci <email@example.com>||Tue Nov 29 20:58:30 2022|
|committer||LUCI CQ <firstname.lastname@example.org>||Tue Nov 29 20:58:30 2022|
[common/system/filesystem] common ancestor fixes and more tests. Some cases weren't well tested in the previous CL. This one adds some tests and fixes some revealed bugs. * slashesMatch was incorrect due to an off by one error (it would compare [0, 12] vs [0, 12] for whichSlash==2, but really should have compared [0, 12, 15] vs [0, 12, 19]. * We now explicitly check that all paths share the same Volume. If they do not, then they cannot have a common ancestor. R=rgw, vadimsh Change-Id: I06b22e0358879f613a40ab298c8beb43b7a2cd96 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/4062996 Reviewed-by: Riley Wong <email@example.com> Reviewed-by: Vadim Shtayura <firstname.lastname@example.org> Commit-Queue: Robbie Iannucci <email@example.com>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
It is now possible to directly install tools with go install:
go install go.chromium.org/luci/auth/client/cmd/...@latest go install go.chromium.org/luci/buildbucket/cmd/...@latest go install go.chromium.org/luci/cipd/client/cmd/...@latest go install go.chromium.org/luci/client/cmd/...@latest go install go.chromium.org/luci/cv/cmd/...@latest go install go.chromium.org/luci/gce/cmd/...@latest go install go.chromium.org/luci/grpc/cmd/...@latest go install go.chromium.org/luci/logdog/client/cmd/...@latest go install go.chromium.org/luci/luci_notify/cmd/...@latest go install go.chromium.org/luci/lucicfg/cmd/...@latest go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest go install go.chromium.org/luci/mailer/cmd/...@latest go install go.chromium.org/luci/mmutex/cmd/...@latest go install go.chromium.org/luci/resultdb/cmd/...@latest go install go.chromium.org/luci/server/cmd/...@latest go install go.chromium.org/luci/swarming/cmd/...@latest go install go.chromium.org/luci/tokenserver/cmd/...@latest go install go.chromium.org/luci/tools/cmd/...@latest
Contributing uses the same flow as Chromium contributions.