Revert "[bbagent] only populate missing swarming info if build.Infra.Backend is also empty"

This reverts commit 9bd25fdd11cc5ff3b99090613643d0efbf9e558d.

Reason for revert: This is suspicious to cause all dev build failures.
https://screenshot.googleplex.com/99VDCLRGRgX76JJ 

https://chromium-swarm-dev.appspot.com/task?id=686cd188adf56610&o=true&w=true
> panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x90 pc=0xb73e5c]

goroutine 1 [running]:
main.backFillTaskInfo({0xeefd58, 0xc0004c7110}, {{0xeebb10?, 0xc000520340?}, 0xc00022cd80?})
	go.chromium.org/luci/buildbucket/cmd/bbagent/main.go:303 +0x2dc
main.mainImpl()
	go.chromium.org/luci/buildbucket/cmd/bbagent/main.go:691 +0xe51
main.main()
	go.chromium.org/luci/buildbucket/cmd/bbagent/main.go:834 +0x1f


Original change's description:
> [bbagent] only populate missing swarming info if build.Infra.Backend is also empty
>
> Change-Id: I0b185a7f45445e5cc119782a4525525df83baa31
> Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5378109
> Auto-Submit: Chan Li <chanli@chromium.org>
> Commit-Queue: Yuanjun Huang <yuanjunh@google.com>
> Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
> Commit-Queue: Chan Li <chanli@chromium.org>

Change-Id: I4404d87347ee3697f4db65beb479fd0f29d57715
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5379765
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
1 file changed
tree: 318306c61256d00dc72acde1a5a78dd11f96d0e2
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. resultdb/
  33. scheduler/
  34. scripts/
  35. server/
  36. standalone/
  37. starlark/
  38. swarming/
  39. teams/
  40. third_party/
  41. tokenserver/
  42. tools/
  43. tree_status/
  44. vpython/
  45. web/
  46. .gitallowed
  47. .gitattributes
  48. .gitignore
  49. .go-lintable
  50. AUTHORS
  51. codereview.settings
  52. CONTRIBUTING.md
  53. CONTRIBUTORS
  54. go.mod
  55. go.sum
  56. LICENSE
  57. OWNERS
  58. PRESUBMIT.py
  59. README.md
  60. tools.go
  61. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.