commit | 500dce22903a342eba82b2985162e3bcbb51129d | [log] [tgz] |
---|---|---|
author | Junji Watanabe <jwata@google.com> | Tue Mar 19 05:58:41 2024 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 19 05:58:41 2024 |
tree | 318306c61256d00dc72acde1a5a78dd11f96d0e2 | |
parent | 03ca27aceea6d9e30d29402c4a2ec6c75cacad77 [diff] |
Revert "[bbagent] only populate missing swarming info if build.Infra.Backend is also empty" This reverts commit 9bd25fdd11cc5ff3b99090613643d0efbf9e558d. Reason for revert: This is suspicious to cause all dev build failures. https://screenshot.googleplex.com/99VDCLRGRgX76JJ https://chromium-swarm-dev.appspot.com/task?id=686cd188adf56610&o=true&w=true > panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x90 pc=0xb73e5c] goroutine 1 [running]: main.backFillTaskInfo({0xeefd58, 0xc0004c7110}, {{0xeebb10?, 0xc000520340?}, 0xc00022cd80?}) go.chromium.org/luci/buildbucket/cmd/bbagent/main.go:303 +0x2dc main.mainImpl() go.chromium.org/luci/buildbucket/cmd/bbagent/main.go:691 +0xe51 main.main() go.chromium.org/luci/buildbucket/cmd/bbagent/main.go:834 +0x1f Original change's description: > [bbagent] only populate missing swarming info if build.Infra.Backend is also empty > > Change-Id: I0b185a7f45445e5cc119782a4525525df83baa31 > Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5378109 > Auto-Submit: Chan Li <chanli@chromium.org> > Commit-Queue: Yuanjun Huang <yuanjunh@google.com> > Reviewed-by: Yuanjun Huang <yuanjunh@google.com> > Commit-Queue: Chan Li <chanli@chromium.org> Change-Id: I4404d87347ee3697f4db65beb479fd0f29d57715 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5379765 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Fumitoshi Ukai <ukai@google.com> Auto-Submit: Junji Watanabe <jwata@google.com>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
It is now possible to directly install tools with go install:
go install go.chromium.org/luci/auth/client/cmd/...@latest go install go.chromium.org/luci/buildbucket/cmd/...@latest go install go.chromium.org/luci/cipd/client/cmd/...@latest go install go.chromium.org/luci/client/cmd/...@latest go install go.chromium.org/luci/cv/cmd/...@latest go install go.chromium.org/luci/gce/cmd/...@latest go install go.chromium.org/luci/grpc/cmd/...@latest go install go.chromium.org/luci/logdog/client/cmd/...@latest go install go.chromium.org/luci/luci_notify/cmd/...@latest go install go.chromium.org/luci/lucicfg/cmd/...@latest go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest go install go.chromium.org/luci/mailer/cmd/...@latest go install go.chromium.org/luci/mmutex/cmd/...@latest go install go.chromium.org/luci/resultdb/cmd/...@latest go install go.chromium.org/luci/server/cmd/...@latest go install go.chromium.org/luci/swarming/cmd/...@latest go install go.chromium.org/luci/tokenserver/cmd/...@latest go install go.chromium.org/luci/tools/cmd/...@latest
Contributing uses the same flow as Chromium contributions.