|author||Seth Koehler <email@example.com>||Tue Dec 19 18:59:33 2017|
|committer||Commit Bot <firstname.lastname@example.org>||Wed Dec 20 15:41:59 2017|
Fix race condition (COMPLETED/BOT_DIED) in task_runner. Per b/69462084 and a TODO comment in this file, a race condition exists when an external process polls task status that fails with BOT_DIED (there's a short window in which the task will be marked as COMPLETED before being updated to BOT_DIED). This change sends the task-update without the exit code (to prevent the COMPLETED status from being set), and then sends a task_error message. The default must_signal_internal_failure is also changed to provide a default error in case run_isolated fails. TESTED=Ran unit tests in task_runner_test and they pass. Any other tests? Change-Id: I1db3e15ccbdac3da9181b273681180211b07841c Reviewed-on: https://chromium-review.googlesource.com/834397 Commit-Queue: Marc-Antoine Ruel <email@example.com> Reviewed-by: Marc-Antoine Ruel <firstname.lastname@example.org>
LUCI is an ensemble of services that work together to run large scale CI (continuous integration) infrastructure to get results in O(1). It is used by the Chromium project.
See appengine/ for the services provided.
A complete CI toolkit:
masterconstains the latest code.
stablecontains the stable code.
user.nameare configured in
Run the following to setup the code review tool and create your first review:
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" cd luci-py git checkout -b work origin/master # hack hack git commit -a -m "This is awesome\nRemail@example.com" # This will ask for your Google Account credentials. git cl upload -s # Wait for LGTM over email. # Check the commit queue box in codereview website. # Wait for the change to be tested and landed automatically.
git cl help and
git cl help <cmd> for more details.
This project is licensed under Apache v2.0 license. See LICENSE for details.