Google Git
Sign in
chromium / infra / luci / recipes-py.git / 045c03f5893976022b1625961f8f111d74b43aa0
commit045c03f5893976022b1625961f8f111d74b43aa0[log] [tgz]
authorRob Mohr <mohrr@google.com>Tue May 28 22:21:58 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 28 22:21:58 2024
tree21ad6e1d15aff7d23bc5e4388764af36e1256249
parentece005ce6b602d8ce89184853a11dfe1955b3ffd [diff]
[post_process] Add deprecation warnings

Add deprecation warnings to some post-process checks. The post-process
checks don't issue warnings directly but are decorated with them and the
warnings are ultimately issued when the check is added to the test.

This repository doesn't use these deprecated checks, so this was tested
with the infra/infra repository:

  **********************************************************************
       WARNING: recipe_engine/POST_PROCESS_RESULTREASON_DEPRECATED
                  Found 7 call sites and 0 import sites
  **********************************************************************
  Description:
    ResultReason and ResultReasonRE are deprecated.

    Use StatusAnyFailure + SummaryMarkdown(RE) instead.
  Deadline: 2024-08-01

  Bug Link: https://crbug.com/339834630
  Call Sites:
    ~/recipes/recipe_modules/support_3pp/tests/full.py:774 (and 822, 862, 1316, 1337)
    ~/recipes/recipes/build_wheels.py:218 (and 226)

Bug: 339834630
Change-Id: Ibc8114ada82becc03021fc30ac0d97b2149e970a
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/5531438
Auto-Submit: Rob Mohr <mohrr@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
3 files changed
tree: 21ad6e1d15aff7d23bc5e4388764af36e1256249
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .editorconfig
  10. .gitattributes
  11. .gitignore
  12. .pycharm.vpython3
  13. .style.yapf
  14. .vpython3
  15. .vscode.vpython3
  16. AUTHORS
  17. codereview.settings
  18. CONTRIBUTORS
  19. LICENSE
  20. OWNERS
  21. PRESUBMIT.py
  22. pyproject.toml
  23. README.md
  24. README.recipes.md
  25. recipe.warnings
  26. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.

They allow writing build flows which integrate with the rest of LUCI.

Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

# Get `depot_tools` in $PATH if you don't have it
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"

# Check out the recipe engine repo
git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py

# make your change
cd $HOME/src/recipes-py
git new-branch cool_feature
# hack hack
git commit -a -m "This is awesome"

# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.