Set py3_only for recipe-engine.

Because of the way the integration tests work, this also required
updating basically all the tests.

I converted all tests in the engine repo to pass under python3,
adjusting their shebang lines, etc. Running them under python2
will likely no longer work, but python2 is not fully ripped out
in this CL.

`git cl presubmit` now runs cleanly for me w/ vpython3 in PATH.

Fixes a cadre of bugs which were related to running the tests
and/or python2, and/or python3 conversion things which were missed.

R=yiwzhang@google.com

Bug: 1298328
Change-Id: Ida8f038aa63ff07e6d7b1f8d80f8ec63dd269c4d
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/4350877
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
45 files changed
tree: c99101f12b6f5dc774e82e298c62f7f77c2f4b86
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .gitattributes
  10. .gitignore
  11. .style.yapf
  12. .vpython
  13. .vpython3
  14. .vpython3_dev
  15. AUTHORS
  16. codereview.settings
  17. CONTRIBUTORS
  18. LICENSE
  19. OWNERS
  20. PRESUBMIT.py
  21. README.md
  22. README.recipes.md
  23. recipe.warnings
  24. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.

They allow writing build flows which integrate with the rest of LUCI.

Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

# Get `depot_tools` in $PATH if you don't have it
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"

# Check out the recipe engine repo
git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py

# make your change
cd $HOME/src/recipes-py
git new-branch cool_feature
# hack hack
git commit -a -m "This is awesome"

# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.