| commit | 6e8c5b042fa93e5518f8db1abe7eb8f783565908 | [log] [tgz] |
|---|---|---|
| author | Andrii Shyshkalov <tandrii@google.com> | Wed Aug 18 11:45:37 2021 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 18 11:45:37 2021 |
| tree | 28621cf737ee927d0d19e53fb1f16cdd4177e1af | |
| parent | 56ae637ef23b9ca9b7d22ec466e566d3742bcc63 [diff] |
Revert "[tricium] be less stringent about posted comments." This reverts commit eb6ff897b261d8850d4bed2d3eb4b58694394ec0. Reason for revert: nope, Gerrit refuses accepting comment for range: (line=88,pos=5) .. (line=88,pos=0) and at the same time when sent: (line=88,pos=5) .. (line=89,pos=0) Gerrit marks entire L89 as commented upon. Original change's description: > [tricium] be less stringent about posted comments. > > Turns out the comment with input: > https://tricium-prod.appspot.com/rpcexplorer/services/tricium.Tricium/Results?request={%20%20%20%20%22runId%22:%20%225575029453488128%22} > > "startLine": 95, > > "endLine": 96, > > "startChar": 14 > Actually covers entire L96 line, for unclear to me reasons: > https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3093095/1/buildbucket/appengine/rpc/batch.go#96 > > So, it probably makes sense to emit comment for: > > "startLine": 95, > > "endLine": 95, > > "startChar": 14 > where implied endChar is end of L95 line. > > R=​yiwzhang > > Bug: 1239584 > Change-Id: I8568684dda5c90884cbbee9cfbb9952461ec5a4d > Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/3094017 > Commit-Queue: Andrii Shyshkalov <tandrii@google.com> > Commit-Queue: Yiwei Zhang <yiwzhang@google.com> > Auto-Submit: Andrii Shyshkalov <tandrii@google.com> > Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Bug: 1239584 Change-Id: Ib79c36d9313fd75a3f3f85be5eef1015b072b8f4 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/3103368 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.
They allow writing build flows which integrate with the rest of LUCI.
Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.
user.email and user.name are configured in git config.Run the following to setup the code review tool and create your first review:
# Get `depot_tools` in $PATH if you don't have it git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" # Check out the recipe engine repo git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py # make your change cd $HOME/src/recipes-py git new-branch cool_feature # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r joe@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
Use git cl help and git cl help <cmd> for more details.