| commit | 900b191fea68d1c0869204ec58ed0710fbacd283 | [log] [tgz] |
|---|---|---|
| author | Quinten Yearsley <qyearsley@chromium.org> | Thu Jan 07 23:44:01 2021 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 07 23:44:01 2021 |
| tree | a7f42a1ccb9c79f8453725e44619eee00cb6d63f | |
| parent | a0af0123ab934330280360700d919c074caffa95 [diff] |
tricium: Remove hard limit on num comments in recipe module At the recipe stage, we don't know yet which lines will be filtered, so setting a max comment number here will prevent Tricium from posting comments even when only a small number of comments are actually in changed lines. I kept the warning because it may be useful if someone is wondering why Tricium didn't post comments and there were a large number of comments generated. Bug: 1163911 Change-Id: I5a38e42e4cf2546cfd776720144e1c4d733959fb Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/2616103 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.
They allow writing build flows which integrate with the rest of LUCI.
Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.
user.email and user.name are configured in git config.Run the following to setup the code review tool and create your first review:
# Get `depot_tools` in $PATH if you don't have it git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" # Check out the recipe engine repo git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py # make your change cd $HOME/src/recipes-py git new-branch cool_feature # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r joe@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
Use git cl help and git cl help <cmd> for more details.