Google Git
Sign in
chromium / infra / luci / recipes-py.git / a7d70e51458befe4095afb64cb1680d933b06f6d
commita7d70e51458befe4095afb64cb1680d933b06f6d[log] [tgz]
authorGarrett Beaty <gbeaty@chromium.org>Wed May 08 20:08:32 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 08 20:08:32 2024
tree2a00605e964505cf795f6fcd44e745e9f6446ad8
parent9bf82361f22c960ff5dd1f0d4e9b124a3a3e9721 [diff]
Update path comparisons to use common conventions.

Equality and ordering operators shouldn't assume the type of the second
argument, instead they should return NotImplemented for objects of types
where the comparison isn't supported. This ensures the standard behavior
where mixed types compare unequal and raise a TypeError indicating that
ordering isn't supported. Without this change, attempting to compare a
Path with a non-str/Path object results in a misleading exception of the
form:
"ValueError: Path.__eq__ invalid for mismatched bases (CheckoutBasePath vs ResolvedBasePath) before checkout_dir is set"

Change-Id: I7c7c901e515a96b5913c9e0a2f3277461a91cb0e
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/5506095
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
2 files changed
tree: 2a00605e964505cf795f6fcd44e745e9f6446ad8
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .editorconfig
  10. .gitattributes
  11. .gitignore
  12. .pycharm.vpython3
  13. .style.yapf
  14. .vpython3
  15. .vscode.vpython3
  16. AUTHORS
  17. codereview.settings
  18. CONTRIBUTORS
  19. LICENSE
  20. OWNERS
  21. PRESUBMIT.py
  22. pyproject.toml
  23. README.md
  24. README.recipes.md
  25. recipe.warnings
  26. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.

They allow writing build flows which integrate with the rest of LUCI.

Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

# Get `depot_tools` in $PATH if you don't have it
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"

# Check out the recipe engine repo
git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py

# make your change
cd $HOME/src/recipes-py
git new-branch cool_feature
# hack hack
git commit -a -m "This is awesome"

# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.