Google Git
Sign in
chromium / infra / luci / recipes-py.git / f3a3b6e2d0d3f187f3d94de72bd7d9c5e5f85bf3
commitf3a3b6e2d0d3f187f3d94de72bd7d9c5e5f85bf3[log] [tgz]
authorGarrett Beaty <gbeaty@chromium.org>Fri Jun 21 18:11:02 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jun 21 18:11:02 2024
tree1409ac009ef341c5d84ea88d8da1642341016204
parentc5245039e2e0747b874fcfd1918722a0592cac3a [diff]
Prevent joining paths with None.

Currently if a Path is joined with None either using the joinpath method
or the / operator, the None gets ignored because all falsey values get
skipped over. This is the appropriate action for an empty string, but
None should be rejected in order to behave more similarly to the pathlib
Path type.

Bug: 329113288
Change-Id: Iad1e38ed422dcddfabf9490c2c2f917e69c625c4
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/5641413
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
2 files changed
tree: 1409ac009ef341c5d84ea88d8da1642341016204
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .editorconfig
  10. .gitattributes
  11. .gitignore
  12. .pycharm.vpython3
  13. .style.yapf
  14. .vpython3
  15. .vscode.vpython3
  16. AUTHORS
  17. codereview.settings
  18. CONTRIBUTORS
  19. LICENSE
  20. OWNERS
  21. PRESUBMIT.py
  22. pyproject.toml
  23. README.md
  24. README.recipes.md
  25. recipe.warnings
  26. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.

They allow writing build flows which integrate with the rest of LUCI.

Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

# Get `depot_tools` in $PATH if you don't have it
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"

# Check out the recipe engine repo
git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py

# make your change
cd $HOME/src/recipes-py
git new-branch cool_feature
# hack hack
git commit -a -m "This is awesome"

# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.