| commit | ff5ce51ceaaa7a62275bb766831a3ce1e88de37d | [log] [tgz] |
|---|---|---|
| author | Struan Shrimpton <sshrimp@google.com> | Wed Nov 23 23:52:43 2022 |
| committer | Yiwei Zhang <yiwzhang@google.com> | Wed Nov 23 23:52:43 2022 |
| tree | 18ec0f959857aea9c1619af07fcdfcff9dc831a3 | |
| parent | 189a0bb4a1d2f670f0a1c72d9d616bd36bfb4d63 [diff] |
Revert "Check created_by to ensure cq tags were copied on retry builds" This reverts commit a2528d57f44f5598788d3dd4d093895cfa77836b. Reason for revert: This breaks our compilators (eg https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel-compilator/431592/overview) and presumably any other build that relies on cq when launched by another builder Original change's description: > Check created_by to ensure cq tags were copied on retry builds > > Gerrit appears to be inconsistently copying cq tags on retry builds. > To ensure we don't get ValueErrors like in: > https://crrev.com/c/4006099/3 > This will additionally check that the created_by starts with project > to ensure the cq tags that cq.active protect are actually there. > > Downstream chromiumos CL: https://crrev.com/c/4024425 > Downstream build CL: https://crrev.com/c/4021393 > > Recipe-Nontrivial-Roll: chromiumos > Bug: 1382577 > Change-Id: I3d40b4931bc046f6469ebee2365bcf41fc875634 > Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/4018830 > Reviewed-by: Yiwei Zhang <yiwzhang@google.com> > Commit-Queue: Struan Shrimpton <sshrimp@google.com> Bug: 1382577 Change-Id: I9aa00934b1b2590da7b496b314821a9792f5b89e Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/4044016 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.
They allow writing build flows which integrate with the rest of LUCI.
Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.
user.email and user.name are configured in git config.Run the following to setup the code review tool and create your first review:
# Get `depot_tools` in $PATH if you don't have it git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" # Check out the recipe engine repo git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py # make your change cd $HOME/src/recipes-py git new-branch cool_feature # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r joe@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
Use git cl help and git cl help <cmd> for more details.