Google Git
Sign in
chromium / infra / luci / recipes-py / 01ba86a23a3beabc5f51642658baa726d0ed112c
commit01ba86a23a3beabc5f51642658baa726d0ed112c[log] [tgz]
authorBen Pastene <bpastene@chromium.org>Tue May 14 21:54:18 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 14 21:54:18 2024
tree2835d5ab03fc7edac1ee74bdd929a2def37b3eb9
parentfaa0710ec6293ed081ef480f84988408689e5675 [diff]
Properly propagate CV recipe_mod props to custom child builds

At some point the recipe engine repo set a "deprecation" warning on
uses of the cq recipe module, directing recipes to instead use the cv
recipe module.

However, the cv recipe module's props_for_child_build() method only sets
props for the cq recipe module. This means that props_for_child_build()
effectively broke (and became a no-op) for anyone that migrated to the
cv recipe module since it wasn't setting any props that it would
recognize.

So this fixes that.

Recipe-Nontrivial-Roll: chromiumos
Bug: 333811087
Change-Id: I39b7c63bf84322dde90b45e1b39328dad56d8934
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/5537835
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
2 files changed
tree: 2835d5ab03fc7edac1ee74bdd929a2def37b3eb9
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .editorconfig
  10. .gitattributes
  11. .gitignore
  12. .pycharm.vpython3
  13. .style.yapf
  14. .vpython3
  15. .vscode.vpython3
  16. AUTHORS
  17. codereview.settings
  18. CONTRIBUTORS
  19. LICENSE
  20. OWNERS
  21. PRESUBMIT.py
  22. pyproject.toml
  23. README.md
  24. README.recipes.md
  25. recipe.warnings
  26. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.

They allow writing build flows which integrate with the rest of LUCI.

Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

# Get `depot_tools` in $PATH if you don't have it
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"

# Check out the recipe engine repo
git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py

# make your change
cd $HOME/src/recipes-py
git new-branch cool_feature
# hack hack
git commit -a -m "This is awesome"

# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.