| commit | 10831cb71d94c8b3fa54df8c6bb0beb870072566 | [log] [tgz] |
|---|---|---|
| author | Oliver Newman <olivernewman@google.com> | Tue Jun 23 23:15:39 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jun 23 23:15:39 2020 |
| tree | 235f100cb409999eb9d8b9b4e87e773193e9140c | |
| parent | fad8098894906796ad442b560a680ccc444fc524 [diff] |
[lint] Add attr to import whitelist The attr module cannot touch external state and is used widely throughout recipes, so it makes sense to add it to this whitelist. The only reason this hasn't caused an issue before now is that attr is mostly used by recipe modules, and `recipes.py lint` doesn't support validation of recipe module imports yet. I also renamed some variables to avoid "whitelist", for the purposes of inclusivity. I didn't change anything user-facing like argument names or help strings. Change-Id: I860cad13c3960fb74a8745fafc8c11d0ed25be97 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/2261077 Commit-Queue: Oliver Newman <olivernewman@google.com> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.
They allow writing build flows which integrate with the rest of LUCI.
Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.
user.email and user.name are configured in git config.Run the following to setup the code review tool and create your first review:
# Get `depot_tools` in $PATH if you don't have it git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" # Check out the recipe engine repo git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py # make your change cd $HOME/src/recipes-py git new-branch cool_feature # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r joe@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
Use git cl help and git cl help <cmd> for more details.