[swarming] Make TaskResult.output_dir a Path

Uses output_dir.join(...) instead of api.path.join(output_dir, ...) to
construct the swarming TaskResult output_dir. This makes the output_dir
a Path rather than a string, for better compatibility with recipes that
use the swarming module.

This change is technically not backward compatible, because the
output_dir argument to api.swarming.collect() can now only be a Path,
not a string. However, the docstring already indicated that it only
accepted Paths. And based on a quick code search, there doesn't seem to
be any recipe code that passes a string as the output_dir, so this
should be safe.

I also renamed the `id` variable to fix pylint's complaint that it
conflicts with the id() built-in.

Test: https://ci.chromium.org/swarming/task/46446502767d6710?server=chromium-swarm.appspot.com
Change-Id: I83d4ee157f6f264afcc3547d0b376f24673bd3b4
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1719380
Commit-Queue: Oliver Newman <olivernewman@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Joshua Seaton <joshuaseaton@google.com>
1 file changed
tree: 56d6022c435edd170920688d412c46e631d64455
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .gitattributes
  10. .gitignore
  11. .style.yapf
  12. .vpython
  14. codereview.settings
  17. OWNERS
  18. PRESUBMIT.py
  19. README.md
  20. README.recipes.md
  21. recipes.py


Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.

They allow writing build flows which integrate with the rest of LUCI.

Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.


  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

# Get `depot_tools` in $PATH if you don't have it
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"

# Check out the recipe engine repo
git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py

# make your change
cd $HOME/src/recipes-py
git new-branch cool_feature
# hack hack
git commit -a -m "This is awesome"

# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.