Google Git
Sign in
chromium / infra / luci / recipes-py / 1da1b1c82a6afb861ec5091970e194726521bb8d
commit1da1b1c82a6afb861ec5091970e194726521bb8d[log] [tgz]
authorGreg Edelston <gredelston@google.com>Wed Jul 31 21:03:12 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 31 21:03:12 2024
treedb3f2057265fe186b5830a71bb527358a4c1dc35
parent8234f784733e000b6604e931184de223beb41d24 [diff]
time: Force exception when sleeping after shutdown

Sleeping after shutdown should cause an exception to be raised. However,
if with_step=False, then no step gets run, so sleep() can silently exit.
Thus, if sleep(with_step=None) is called after GLOBAL_SHUTDOWN, then we
should default with_step to True to force the exception.

BUG=b:356438386
TEST=./recipes.py test train

Change-Id: I1ae825708cf394dca60a14187472c6f8f56e4a57
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/5749685
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Greg Edelston <gredelston@google.com>
2 files changed
tree: db3f2057265fe186b5830a71bb527358a4c1dc35
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .editorconfig
  10. .gitattributes
  11. .gitignore
  12. .pycharm.vpython3
  13. .style.yapf
  14. .vpython3
  15. .vscode.vpython3
  16. AUTHORS
  17. codereview.settings
  18. CONTRIBUTORS
  19. LICENSE
  20. OWNERS
  21. PRESUBMIT.py
  22. pyproject.toml
  23. README.md
  24. README.recipes.md
  25. recipe.warnings
  26. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.

They allow writing build flows which integrate with the rest of LUCI.

Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

# Get `depot_tools` in $PATH if you don't have it
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"

# Check out the recipe engine repo
git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py

# make your change
cd $HOME/src/recipes-py
git new-branch cool_feature
# hack hack
git commit -a -m "This is awesome"

# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.