Google Git
Sign in
chromium / infra / luci / recipes-py / 29bd4696ad4267a4944b8837c27ff9794528552f
commit29bd4696ad4267a4944b8837c27ff9794528552f[log] [tgz]
authorRob Mohr <mohrr@google.com>Wed Sep 18 18:45:12 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Sep 18 18:45:12 2024
tree22414273de3b10a7ce84bc767eacb15f3f043233
parent2cacf729f7cdc9b50ffbad14a048686f5585f447 [diff]
[step] Assert step name is non-empty

Fail in the recipe if a step name is empty. Previously, empty step names
resulted in RPC errors that made things hard to track down in MILO (see
https://ci.chromium.org/b/8736442163566096673 for an example).

Change-Id: I69d6faad5efa651ed22b77356c72e81d8047450d
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/5874159
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Rob Mohr <mohrr@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
2 files changed
tree: 22414273de3b10a7ce84bc767eacb15f3f043233
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .editorconfig
  10. .gitattributes
  11. .gitignore
  12. .pycharm.vpython3
  13. .style.yapf
  14. .vpython3
  15. .vscode.vpython3
  16. AUTHORS
  17. codereview.settings
  18. CONTRIBUTORS
  19. LICENSE
  20. OWNERS
  21. PRESUBMIT.py
  22. pyproject.toml
  23. README.md
  24. README.recipes.md
  25. recipe.warnings
  26. recipes.py
  27. SECURITY_TEAM_OWNERS
README.md

Recipes

Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.

They allow writing build flows which integrate with the rest of LUCI.

Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

# Get `depot_tools` in $PATH if you don't have it
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"

# Check out the recipe engine repo
git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py

# make your change
cd $HOME/src/recipes-py
git new-branch cool_feature
# hack hack
git commit -a -m "This is awesome"

# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.