tree c64b2a2b456beecf0fe2f4ecf03a936f88ea95d3
parent adb648a9367a42b95f231933d3e55a5a41954cc9
author Robert Iannucci <iannucci@chromium.org> 1716252106 +0000
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> 1716252106 +0000

[file] Fix bug in read_proto.

Due to a copy/paste error, read_proto took 'encoding_kwargs', which
makes very little sense. The typical use for this is to pass things
like 'ignore_unknown_fields' to the json_format decoder.

However, in the previous implementation, it took 'encoding_kwargs'
and passed this to the decoder AND an encoder (for the log report).

There's not a strong need to control the encoded output (especially
since this encoded output can vary from the selected encoder in
order to avoid dumping binary proto to a text log), so this fixes
the API to just have decoding_kwargs instead.

R=fancl, mohrr

Change-Id: I4d15a8c7030c8bf06a825bc12d1eaf785819f750
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/5552112
Reviewed-by: Chenlin Fan <fancl@chromium.org>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>