[buildbucket] Require commit ref
When accepting an output commit, require ref.
R=tandrii@chromium.org
Bug: 940214
Change-Id: Ic4abca68fecbd154075e1c230a0427f3737f36dc
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1544897
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
diff --git a/recipe_modules/buildbucket/api.py b/recipe_modules/buildbucket/api.py
index e51b42d..44b9079 100644
--- a/recipe_modules/buildbucket/api.py
+++ b/recipe_modules/buildbucket/api.py
@@ -209,13 +209,13 @@
assert not c.project.startswith('a/'), c.project
assert not c.project.endswith('/'), c.project
+ assert c.ref.startswith('refs/'), c.ref
+ assert not c.ref.endswith('/'), c.ref
+
assert util.is_sha1_hex(c.id), c.id
# position is uint32
- assert not c.position or c.ref
-
- assert not c.ref or c.ref.startswith('refs/'), c.ref
- assert not c.ref.endswith('/'), c.ref
+ # Does not need extra validation.
# The fact that it sets a property value is an implementation detail.
res = self.m.step('set_output_gitiles_commit', cmd=None)
