Google Git
Sign in
chromium / infra / luci / recipes-py / a4e5d51c4351ab0674e264a8a360572286b04a6f
commita4e5d51c4351ab0674e264a8a360572286b04a6f[log] [tgz]
authorBrian Ryner <bryner@google.com>Mon Dec 12 22:28:44 2022
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Dec 12 22:28:44 2022
tree9972a188b0626100bbd5634eb060fd5bae91a51d
parent51744397684b314c7557a21d251598c5090e79f4 [diff]
Convert output to a string before calling replacer.

This is necessary for py3 compatibility where Popen output is bytes.

Change-Id: I6fe8e84e6db00b6e06597c05f320e220d9da60ae
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/4096097
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
1 file changed
tree: 9972a188b0626100bbd5634eb060fd5bae91a51d
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .gitattributes
  10. .gitignore
  11. .style.yapf
  12. .vpython
  13. .vpython3
  14. .vpython3_dev
  15. AUTHORS
  16. codereview.settings
  17. CONTRIBUTORS
  18. LICENSE
  19. OWNERS
  20. PRESUBMIT.py
  21. README.md
  22. README.recipes.md
  23. recipe.warnings
  24. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.

They allow writing build flows which integrate with the rest of LUCI.

Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

# Get `depot_tools` in $PATH if you don't have it
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"

# Check out the recipe engine repo
git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py

# make your change
cd $HOME/src/recipes-py
git new-branch cool_feature
# hack hack
git commit -a -m "This is awesome"

# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.