| commit | d04772786228c57101414c91ab1e64e2518c403c | [log] [tgz] |
|---|---|---|
| author | Garrett Beaty <gbeaty@chromium.org> | Thu May 12 20:17:16 2022 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu May 12 20:17:16 2022 |
| tree | 29428cf1dd0b3e55f76778ef3a27a31961040835 | |
| parent | bb1fb5af7df7af67167321440d19dd855abc7518 [diff] |
Inhibit displaying coverage information on python3 failures with --stop. Currently if the --stop flag is passed and a failure occurs on a python2 tests, the coverage information is not displayed because the execute_queue function won't save the coverage data in the event of a failure, so the reporter won't report anything. However, if a failure occurs in a python3 test, it ends up displaying incomplete coverage information because the coverage data for python2 tests will be saved. This changes it to track if there were failures for either python version and prevents the coverage report from being display if there were any failures when the --stop flag is set. Change-Id: Iac4bb1b75091f8e7a7ba89ac2d0a2331b4edc7d6 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/3645569 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Garrett Beaty <gbeaty@google.com>
Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.
They allow writing build flows which integrate with the rest of LUCI.
Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.
user.email and user.name are configured in git config.Run the following to setup the code review tool and create your first review:
# Get `depot_tools` in $PATH if you don't have it git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" # Check out the recipe engine repo git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py # make your change cd $HOME/src/recipes-py git new-branch cool_feature # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r joe@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
Use git cl help and git cl help <cmd> for more details.