|author||Robert Iannucci <email@example.com>||Fri Mar 29 00:40:07 2019|
|committer||Commit Bot <firstname.lastname@example.org>||Fri Mar 29 00:40:07 2019|
[fetch] Mark commits which touch .gitattributes as "interesting". This check is a bit presumptuous; it assumes that all modifications to .gitattributes files are interesting to recipes which is certainly not true. However, the alternatives are tricky: 1. Modify the gitattr checker logic in the recipe engine to see if the set of 'recipe files' changes with and without the .gitattributes modification. This would require probing a lot more data from git than the engine does currently. 2. Load the diff of .gitattributes to see if it mentions the 'recipes' tag. This is less work than option 1, and more accurate than the current CL, but still not totally accurate (though likely very close to perfect). I think, for now, the current CL is a "good enough" approximation of the correct behavior :) Remail@example.com, firstname.lastname@example.org, email@example.com Bug: 938601 Change-Id: Idb5dff09b0f707d6eeb716ffe3d86c5d0b8d3e56 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1544893 Auto-Submit: Robbie Iannucci <firstname.lastname@example.org> Commit-Queue: Stephen Martinis <email@example.com> Reviewed-by: Stephen Martinis <firstname.lastname@example.org>
Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.
Documentation for the recipe engine (including this file!). See the design doc for more detailed design information about the recipe engine.
Chrome infra config files.
The main entry point to the recipe engine. It has many subcommands and flags; run
recipes.py -h to see them. Include this in your repository to start using recipes.
Recipes in the recipe engine. These are either example recipes, or recipes which are used to test the engine (see run_test.py to see these run)
Built in recipe modules. These are very useful when writing recipes; take a look in there, and look at each of their
examples subfolders to get an idea how to use them in a recipe.
The core functionality of the recipe engine. Noteworthy files include:
main.py-- The main entrypoint for the recipe engine.
recipes_cfg.proto-- The protobuf file which defines the format of a
third_party/-- third_party code which is vendored into the recipe engine.
recipe_api.py-- The api exposed to a recipe module.
unittests-- Unittests for the engine.
There are also several files which correspond to a subcommand of recipes.py;
autoroll are some examples.
Somewhat poorly named, these are higher level integration tests.
user.nameare configured in
Run the following to setup the code review tool and create your first review:
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" git checkout -b work origin/master # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r email@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
git cl help and
git cl help <cmd> for more details.