Google Git
Sign in
chromium / infra / luci / recipes-py / ee0e2c37c03936c3683be03d215f58d47d04ee08
commitee0e2c37c03936c3683be03d215f58d47d04ee08[log] [tgz]
authorStephen Martinis <martiniss@google.com>Tue Oct 30 21:56:42 2018
committerCommit Bot <commit-bot@chromium.org>Tue Oct 30 21:56:42 2018
tree5dfd9fff029bfc2182be56299a68cdf91996af0d
parent04620158d8f45c68cc8bc39e30ce4a85c368046a [diff]
Always use new run logic

This will retrain every expectation which includes the '$result' entry,
which is almost all of them.

Some of the StepFailure test expectations don't give any useful information.
This is due to how step failures are used now; as a general way to fail
a build, even when an actual step didn't fail. crbug.com/892792 tracks an
attempt to fix this.

Bug: 646142, 892792
Recipe-Manual-Change: build
Recipe-Manual-Change: infra
Recipe-Manual-Change: skiabuildbot
Recipe-Manual-Change: skia
Recipe-Manual-Change: build_limited_scripts_slave
Recipe-Manual-Change: release_scripts
Recipe-Manual-Change: depot_tools
Change-Id: I2778cdc12118d295c6b569f9abf3b70cd398cf95
Reviewed-on: https://chromium-review.googlesource.com/c/1239574
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
173 files changed
tree: 5dfd9fff029bfc2182be56299a68cdf91996af0d
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipes/
  7. unittests/
  8. .gitattributes
  9. .gitignore
  10. .vpython
  11. AUTHORS
  12. codereview.settings
  13. CONTRIBUTORS
  14. LICENSE
  15. OWNERS
  16. PRESUBMIT.py
  17. README.md
  18. README.recipes.md
  19. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.

Files

  • README.md

    This file!

  • doc/

    Documentation for the recipe engine (including this file!). Also includes doc/recipes.py, which is a file you can include in your repository to start using recipes. See the design doc for more detailed design information about the recipe engine.

  • infra/

    Chrome infra config files.

  • recipes.py

    The main entry point to the recipe engine. It has many subcommands and flags; run recipes.py -h to see them.

  • recipes/

    Recipes in the recipe engine. These are either example recipes, or recipes which are used to test the engine (see run_test.py to see these run)

  • recipe_modules/

    Built in recipe modules. These are very useful when writing recipes; take a look in there, and look at each of their examples subfolders to get an idea how to use them in a recipe.

  • recipe_engine/

    The core functionality of the recipe engine. Noteworthy files include:

    • package.proto -- The protobuf file which defines the format of a recipes.cfg file.
    • third_party/ -- third_party code which is vendored into the recipe engine.
    • recipe_api.py -- The api exposed to a recipe module.
    • unittests -- Unittests for the engine.

    There are also several files which correspond to a subcommand of recipes.py; depgraph, run, and autoroll are some examples.

  • unittests/

    Somewhat poorly named, these are higher level integration tests.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"
git checkout -b work origin/master

# hack hack

git commit -a -m "This is awesome"
# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.