commit | f354bc536dfad84be954dbdceb406f5ee8a215b0 | [log] [tgz] |
---|---|---|
author | Andrii Shyshkalov <tandrii@google.com> | Wed Aug 04 20:46:46 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 04 20:46:46 2021 |
tree | d1bb28563ac2d337fddae3eddad5483d1443f909 | |
parent | 2a458f0bd2ab012c28ec57a3f057edd9bfa844b0 [diff] |
[tricium] perform basic validation of comments posted by analyzers. This may break some analyzer builds which previously looked fine, yet these builds were noops because the comments they produced were being rejected by Gerrit anyway. Better to fail early and visibly. Relevant doc: https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#comment-range R=yiwzhang Bug: 1232910 Change-Id: I601e89691c1e02cc973d359aceff7433397074a0 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/3065660 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.
They allow writing build flows which integrate with the rest of LUCI.
Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.
user.email
and user.name
are configured in git config
.Run the following to setup the code review tool and create your first review:
# Get `depot_tools` in $PATH if you don't have it git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" # Check out the recipe engine repo git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py # make your change cd $HOME/src/recipes-py git new-branch cool_feature # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r joe@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
Use git cl help
and git cl help <cmd>
for more details.