[tricium] perform basic validation of comments posted by analyzers.

This may break some analyzer builds which previously looked fine,
yet these builds were noops because the comments they produced
were being rejected by Gerrit anyway.

Better to fail early and visibly.

Relevant doc:
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#comment-range

R=yiwzhang

Bug: 1232910
Change-Id: I601e89691c1e02cc973d359aceff7433397074a0
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/3065660
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
5 files changed
tree: d1bb28563ac2d337fddae3eddad5483d1443f909
  1. doc/
  2. infra/
  3. misc/
  4. recipe_engine/
  5. recipe_modules/
  6. recipe_proto/
  7. recipes/
  8. unittests/
  9. .gitattributes
  10. .gitignore
  11. .style.yapf
  12. .vpython
  13. .vpython3
  14. .vpython3_dev
  15. AUTHORS
  16. codereview.settings
  17. CONTRIBUTORS
  18. LICENSE
  19. OWNERS
  20. PRESUBMIT.py
  21. README.md
  22. README.recipes.md
  23. recipes.py
README.md

Recipes

Recipes are a domain-specific language (embedded in Python) for specifying sequences of subprocess calls in a cross-platform and testable way.

They allow writing build flows which integrate with the rest of LUCI.

Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.

Run the following to setup the code review tool and create your first review:

# Get `depot_tools` in $PATH if you don't have it
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"

# Check out the recipe engine repo
git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py

# make your change
cd $HOME/src/recipes-py
git new-branch cool_feature
# hack hack
git commit -a -m "This is awesome"

# This will ask for your Google Account credentials.
git cl upload -s -r joe@example.com
# Wait for approval over email.
# Click "Submit to CQ" button or ask reviewer to do it for you.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.