Additional improvements to install scripts
Continued from issue 10790023

Changed os.path.expandvars to os.getenv where possible, removed unused imports.

http://codereview.chromium.org/10790023/diff/12/visual_studio/NativeClientVSA...
File visual_studio/NativeClientVSAddIn/InstallerResources/install.py (right):

http://codereview.chromium.org/10790023/diff/12/visual_studio/NativeClientVSA...
visual_studio/NativeClientVSAddIn/InstallerResources/install.py:22:
nacl_sdk_root = os.path.expandvars('%NACL_SDK_ROOT%', None)
I still like os.getenv better here (it doesn't require the platform specific
%VAR%), but OK

http://codereview.chromium.org/10790023/diff/12/visual_studio/NativeClientVSA...
visual_studio/NativeClientVSAddIn/InstallerResources/install.py:24: if
nacl_sdk_root == None:
Tests against None are usually written

if nacl_sdk_root is None:

or

if nacl_sdk_root:

http://codereview.chromium.org/10790023/diff/12/visual_studio/NativeClientVSA...
visual_studio/NativeClientVSAddIn/InstallerResources/install.py:30: addInDir =
os.path.expandvars(
nit: should be add_in_dir

http://codereview.chromium.org/10790023/diff/12/visual_studio/NativeClientVSA...
File visual_studio/NativeClientVSAddIn/create_package.py (right):

http://codereview.chromium.org/10790023/diff/12/visual_studio/NativeClientVSA...
visual_studio/NativeClientVSAddIn/create_package.py:13: import glob
nit: can remove, not used anymore

http://codereview.chromium.org/10790023/diff/12/visual_studio/NativeClientVSA...
visual_studio/NativeClientVSAddIn/create_package.py:15: import shutil
same here

http://codereview.chromium.org/10790023/diff/12/visual_studio/NativeClientVSA...
visual_studio/NativeClientVSAddIn/create_package.py:31: FILE_LIST = [
Nice, a lot easier to read now

BUG=136414
TEST=

Review URL: https://chromiumcodereview.appspot.com/10790039

git-svn-id: https://nativeclient-sdk.googlecode.com/svn/trunk/src@1403 050acbb0-2703-11df-ab0a-9f3f633ae91d
2 files changed