Cherrypick 229035: Fix error checking in get_temp_file_name().

Checking errno without first checking that the call failed means that
if some other call prior to mkstemp failed with EINVAL prior to this,
the assert would fire even if mkstemp succeeded. If something failed
with EEXIST, it would go in to an infinite loop.

Change-Id: I3f140a3e15fe08664a38a8c9a950c4ed547eb481

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@229035 91177308-0d34-0410-b5e6-96231b3b80d8

BUG=none -- infinite looping bot
R=dschuff@chromium.org

Review URL: https://codereview.chromium.org/1092513002

test/support/platform_support.h

diff --git a/test/support/platform_support.h b/test/support/platform_support.h
index 09bb29a..f1f3133 100644
--- a/test/support/platform_support.h
+++ b/test/support/platform_support.h
@@ -62,10 +62,13 @@
     std::string Name;
     int FD = -1;
     do {
-      Name = "libcxx.XXXXXX";
-      FD = mkstemp(&Name[0]);
-      assert(errno != EINVAL && "Something is wrong with the mkstemp's argument");
-    } while (FD == -1 || errno == EEXIST);
+        Name = "libcxx.XXXXXX";
+        FD = mkstemp(&Name[0]);
+        if (FD == -1 && errno == EINVAL) {
+            perror("mkstemp");
+            abort();
+        }
+    } while (FD == -1);
     close(FD);
     return Name;
 #endif