|author||btolsch <firstname.lastname@example.org>||Tue Dec 18 23:13:50 2018|
|committer||Commit Bot <email@example.com>||Thu Dec 20 01:56:19 2018|
Separate mDNS records by interface This change addresses some of the problems with multihomed systems. First, interface addresses should only be advertised on the interface for which they are valid. Second, services are now tied to the first interface on which they are discovered. Hostname collisions from different interfaces are no longer a problem. Bug: openscreen:20 Change-Id: Icc4ea280143abd22d16baaf748dc49e1019a36e3 Reviewed-on: https://chromium-review.googlesource.com/c/1375025 Reviewed-by: Peter Thatcher <firstname.lastname@example.org> Commit-Queue: Brandon Tolsch <email@example.com>
This library implements the Open Screen Protocol. Information about the protocol can be found in the Open Screen GitHub repository.
Open Screen uses LUCI builders to monitor the build and test health of the library.
Coming soon: tryjob and submit queue integration with Gerrit code review.
Open Screen Library code should follow the Open Screen Library Style Guide. In addition, you should also run
//PRESUBMIT.sh before uploading changes for review (which primarily checks formatting).
./tools/install-build-tools.sh from the root source directory to obtain a copy of the following build tools:
You will have to obtain and install these yourself:
Compiler toolchain: Currently, this is
gcc on Linux, and
clang on Mac (from Xcode).
After checking out the Open Screen library, make sure to initialize the submodules for the dependencies. The following commands will checkout all the necessary submodules:
git submodule init git submodule update
The following commands will build the current example executable and run it.
./gn gen out/Default # Creates the build directory and necessary ninja files ninja -C out/Default # Builds the executable with ninja ./out/Default/hello # Runs the executable
-C argument to
ninja works just like it does for GNU Make: it specifies the working directory for the build. So the same could be done as follows:
./gn gen out/Default cd out/Default ninja ./hello
After editing a file, only
ninja needs to be rerun, not
The following sections contain some tips about dealing with Gerrit for code reviews, specifically when pushing patches for review.
There is official Gerrit documentation for this which essentially amounts to:
git push origin HEAD:refs/for/master
You may also wish to install the Change-Id commit-msg hook. This adds a
Change-Id line to each commit message locally, which Gerrit uses to track changes. Once installed, this can be toggled with
git config gerrit.createChangeId <true|false>.
To download the commit-msg hook for the Open Screen repository, use the following command:
curl -Lo .git/hooks/commit-msg https://chromium-review.googlesource.com/tools/hooks/commit-msg
Gerrit keeps track of changes using a Change-Id line in each commit.
When there is no
Change-Id line, Gerrit creates a new
Change-Id for the commit, and therefore a new change. Gerrit's documentation for replacing a change describes this. So if you want to upload a new patchset to an existing review, it should contain the matching
Change-Id line in the commit message.
By default, each commit to your local branch will get its own Gerrit change when pushed, unless it has a
Change-Id corresponding to an existing review.
If you need to modify commits on your local branch to ensure they have the correct
Change-Id, you can do one of two things:
After committing to the local branch, run:
git commit --amend git show
to attach the current
Change-Id to the most recent commit. Check that the correct one was inserted by comparing it with the one shown on
chromium-review.googlesource.com for the existing review.
If you have made multiple local commits, you can squash them all into a single commit with the correct Change-Id:
git rebase -i HEAD~4 git show
where ‘4’ means that you want to squash three additional commits onto an existing commit that has been uploaded for review.