Google Git
Sign in
chromium / v8 / node-ci / 1dbe0e89d5b1c553e2ca24d388177b7de840d853
commit1dbe0e89d5b1c553e2ca24d388177b7de840d853[log] [tgz]
authorYang Guo <yangguo@chromium.org>Tue Feb 19 13:21:18 2019
committerYang Guo <yangguo@chromium.org>Tue Feb 19 14:46:03 2019
tree78fb76ea4d1942df3485e8c83926e18ae4ad4e72
parentd85f8e048721477ac7ce1feae879c8de800a0346 [diff]
Update Node and generate inspector file list

A new file has been added to the inspector target recently,
so it made sense to auto-generate the file list for that target.

R=machenbach@chromium.org

Change-Id: I0836bc972532638c92425990ff5a76299f9b8ceb
Reviewed-on: https://chromium-review.googlesource.com/c/1476404
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
4 files changed
tree: 78fb76ea4d1942df3485e8c83926e18ae4ad4e72
  1. gn/
  2. tools/
  3. build_overrides ⇨ v8/build_overrides
  4. test ⇨ node/test
  5. testing ⇨ v8/testing
  6. .gitignore
  7. .gn
  8. codereview.settings
  9. DEPS
  10. LICENSE
  11. Makefile
  12. README.md
README.md

Node.js built with GN

This project is a set of dependency and build configurations to build Node.js with GN.

Background

V8 was originally built with SCons. Following Chromium, it made the switch to GYP, completing around 2012. That was when Node.js started its success story. However, again following Chromium, V8 made the switch to GN, completing in 2016. So far, Node.js has hesitated in adopting GN. One of the reasons is its now established native modules ecosystem that relies on GYP for build configuration.

Electron, having both Chromium and Node.js as its dependencies, adopted GN. Many files in this repository have been derived from the Electron project, with appropriate changes to avoid the need for forking files, to implement a standalone build, or to fix test failures.

Some reading material:

Instructions

Checking out source

Get depot_tools first.

mkdir node-ci
cd node-ci
fetch node-ci

Alternatively, you can

mkdir node-ci
cd node-ci
git clone https://chromium.googlesource.com/v8/node-ci
gclient config https://chromium.googlesource.com/v8/node-ci --unmanaged

Build

cd node-ci
make deps
make node

Test

JOBS=4 make test

Project priorities

  • Stay as slim as possible. By avoiding to fork files from dependencies, future maintenance becomes less a hassle.
  • Pull necessary sources as dependencies rather than checking in the sources.
  • Stay as up-to-date as possible. The point of this is to be able to build with newest versions of dependencies, including Node.js, V8, and ICU.
  • Simplicity. It should be easy to get up and running.

Not yet implemented

  • Support building on Mac and Windows. The current configurations have only been tested for Linux.
  • Platform-specific OpenSSL build configurations. The current build only supports the slowest platform-independent configuration.

Explicit non-goals

  • To translate every configuration from the GYP build.
  • To support platforms not supported by Chromium.
  • To replace Node.js' test runner with the one used by V8.
  • To use GN to build native modules.

Advantages over upstream Node.js

  • Proper dependency management. Upgrading dependencies is just a small change in DEPS.
  • No need to port V8 changes to GYP.
  • Availability of sanitizers.
  • Toolchain to build is bundled as dependency.