| commit | 5115bea22437450943449a399039f56890262cee | [log] [tgz] |
|---|---|---|
| author | Milad Farazmand <miladfar@ca.ibm.com> | Thu Nov 28 13:24:54 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 28 14:11:45 2019 |
| tree | cf70bccfeb57f90e0472c441b45370e347a03738 | |
| parent | 5d272cf847542ba6e1efbd9b4cda5eee24a74783 [diff] |
[csa] Fix unmatching argument signedness on ComputeSeededHash CodeStubAssembler::ComputeSeededHash is passing key as Int32 to ComputeSeededIntegerHash, but ComputeSeededIntegerHash only accepts Uint32 value. This could cause problems on s390 and ppc because GCC expects any value less than 8 bytes sign/zero-extending to 64-bits by the caller, therefore, the static cast from uint32->uint64 will be treated as no-op (expecting zero-ext instead), which leads to unexpected behaviors. Change-Id: Icd1eecaea1415e36c0c13eef513ff69cc418f247 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940209 Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#65239}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://v8.dev/docs
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote configuration in .git/config:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned at v8.dev/docs/contribute.