| commit | 8171d2d86882086befde06618fd722d294cd4c64 | [log] [tgz] |
|---|---|---|
| author | Simon Zünd <szuend@chromium.org> | Mon May 05 11:25:53 2025 |
| committer | V8 LUCI CQ <v8-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon May 05 13:07:07 2025 |
| tree | 46ec0334f0284396c8a720d30542bafa5784c0cd | |
| parent | cc4e995e1f672a6a5bb667fe99279e4ee64c6f20 [diff] |
[debug] Change for-of/for-in/for-await stepping behavior
This CL changes the stepping behavior for the following 'for' loops:
for (const each of subject) {
for (const each in subject) {
for await (const each of subject) {
Currently we stop before the iterator 'next()' call (or before the
'done' check in the 'in' case). This leads to unintuitive stepping
behavior: For a loop with N iterations, we'll pause N + 1 times on
the 'const each' declaration.
This CL changes the iterator 'next()' call to a unbreakable source
position (to preserve stack traces) and makes the assignment to
the 'each' variable a breakable position instead.
This way, if a loop iterates N times, we'll pause N times on the
'const each' declaration.
R=bmeurer@chromium.org, leszeks@chromium.org
Fixed: 407773675
Change-Id: Id013447a1edeb39bbbffffab71922405e220afed
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6508377
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#100058}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://v8.dev/docs
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote configuration in .git/config:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned at v8.dev/docs/contribute.