| commit | c03151581778a3e52bffcc54c79a81050f7dd584 | [log] [tgz] |
|---|---|---|
| author | Andrés Olivares <andoli@chromium.org> | Thu Feb 06 13:02:32 2025 |
| committer | V8 LUCI CQ <v8-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Feb 06 19:45:12 2025 |
| tree | d099cb4c0c360c3d786f0dbc9df7b7af7177da1b | |
| parent | 8f82330cc7b292abd4aad64ea520cc6b3e5e15b7 [diff] |
Use atomic sequence for sample trace ids I noticed the current approach yielded collisions in the generated sample trace ids on events with close timestamps, likely due to a loss of precision in the way the hash seeds are casted and combined In any case, for the sake of simplicity and performance (given the cost of obtaining a timestamp with base::TimeTicks::now()) this implements a helper that computes a trace id based on an atomic sequential number. Bug: 390155857 Change-Id: I87969a7be30f30001655c63c8d93b49ad8158a00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6227576 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Andres Olivares <andoli@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#98566}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://v8.dev/docs
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote configuration in .git/config:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned at v8.dev/docs/contribute.