| commit | eea2940381f7a178af193c3aa278d85d31a21f1b | [log] [tgz] |
|---|---|---|
| author | Joyee Cheung <joyee@igalia.com> | Wed Feb 22 15:18:30 2023 |
| committer | V8 LUCI CQ <v8-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Feb 27 15:41:38 2023 |
| tree | ced4597d39d3d56d2c0dab2fb75af366f9264831 | |
| parent | eb6447f36e26d7a4ed72be826855715468f329c0 [diff] |
[inspector] fold private methods into a list Previously we display the private methods alongside the fields, as how they are conceptualized by the specification, but this could clutter the UI if the instance being inspected has a long list of private methods which the user usually care less about. This patch folds the private methods found for an object into an internal list (which is an v8::Array with a null prototype, similar to how [[Scopes]] and [[Entries]] are implemented), so the user can fold and expand the list in the UI to have a better view of the object. Before: https://imgur.com/NaD3m4z After: https://imgur.com/7efKyAh Bug: chromium:1292102, chromium:1246904 Change-Id: If260807afd4dd50b1d15897ab8e8a93a4dcaef3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4261416 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#86112}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://v8.dev/docs
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote configuration in .git/config:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned at v8.dev/docs/contribute.