Ship RegExp `dotAll` mode / `s` flag
Intent to ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/0uSHjqvgAwQ/CqmFd6KNAwAJ
BUG=v8:6172
Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
Change-Id: I50fab93516065195b4e9eea0d3be14ccf935a04f
Reviewed-on: https://chromium-review.googlesource.com/589150
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46960}diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index 8d936c5..0455b1c 100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -211,10 +211,9 @@
// Features that are complete (but still behind --harmony/es-staging flag).
#define HARMONY_STAGED(V) \
V(harmony_function_tostring, "harmony Function.prototype.toString") \
- V(harmony_regexp_dotall, "harmony regexp dotall flag") \
V(harmony_regexp_lookbehind, "harmony regexp lookbehind") \
V(harmony_regexp_named_captures, "harmony regexp named captures") \
- V(harmony_regexp_property, "harmony unicode regexp property classes") \
+ V(harmony_regexp_property, "harmony Unicode regexp property classes") \
V(harmony_strict_legacy_accessor_builtins, \
"treat __defineGetter__ and related functions as strict") \
V(harmony_template_escapes, \
@@ -225,10 +224,11 @@
V(harmony_dynamic_import, "harmony dynamic import")
// Features that are shipping (turned on by default, but internal flag remains).
-#define HARMONY_SHIPPING(V) \
- V(harmony_restrictive_generators, \
- "harmony restrictions on generator declarations") \
- V(harmony_object_rest_spread, "harmony object rest spread properties")
+#define HARMONY_SHIPPING(V) \
+ V(harmony_restrictive_generators, \
+ "harmony restrictions on generator declarations") \
+ V(harmony_object_rest_spread, "harmony object rest spread properties") \
+ V(harmony_regexp_dotall, "harmony regexp dotAll flag")
// Once a shipping feature has proved stable in the wild, it will be dropped
// from HARMONY_SHIPPING, all occurrences of the FLAG_ variable are removed,
diff --git a/test/mjsunit/harmony/regexp-dotall-disabled.js b/test/mjsunit/harmony/regexp-dotall-disabled.js
deleted file mode 100644
index 825d384..0000000
--- a/test/mjsunit/harmony/regexp-dotall-disabled.js
+++ /dev/null
@@ -1,71 +0,0 @@
-// Copyright 2017 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// This tests that RegExp dotall features are not enabled when
-// --harmony-regexp-dotall is not passed.
-
-// Flags: --no-harmony-regexp-dotall
-
-// Construction does not throw.
-{
- assertThrows("/./s", SyntaxError);
- assertThrows(() => RegExp(".", "s"), SyntaxError);
- assertThrows(() => new RegExp(".", "s"), SyntaxError);
- assertThrows(() => new RegExp(".", "wtf"), SyntaxError);
-}
-
-// The flags accessors.
-{
- let re = /./gimyu;
- assertEquals("gimuy", re.flags);
- assertTrue(re.global);
- assertTrue(re.ignoreCase);
- assertTrue(re.multiline);
- assertTrue(re.sticky);
- assertTrue(re.unicode);
-
- assertEquals(re.dotAll, undefined);
- assertFalse("dotAll" in re);
-
- let callCount = 0;
- re.__defineGetter__("dotAll", () => { callCount++; return undefined; });
- assertEquals("gimuy", re.flags);
- assertEquals(callCount, 0);
-}
-
-// Default '.' behavior.
-{
- let re = /^.$/;
- assertTrue(re.test("a"));
- assertTrue(re.test("3"));
- assertTrue(re.test("π"));
- assertTrue(re.test("\u2027"));
- assertTrue(re.test("\u0085"));
- assertTrue(re.test("\v"));
- assertTrue(re.test("\f"));
- assertTrue(re.test("\u180E"));
- assertFalse(re.test("\u{10300}")); // Supplementary plane.
- assertFalse(re.test("\n"));
- assertFalse(re.test("\r"));
- assertFalse(re.test("\u2028"));
- assertFalse(re.test("\u2029"));
-}
-
-// Default '.' behavior (unicode).
-{
- let re = /^.$/u;
- assertTrue(re.test("a"));
- assertTrue(re.test("3"));
- assertTrue(re.test("π"));
- assertTrue(re.test("\u2027"));
- assertTrue(re.test("\u0085"));
- assertTrue(re.test("\v"));
- assertTrue(re.test("\f"));
- assertTrue(re.test("\u180E"));
- assertTrue(re.test("\u{10300}")); // Supplementary plane.
- assertFalse(re.test("\n"));
- assertFalse(re.test("\r"));
- assertFalse(re.test("\u2028"));
- assertFalse(re.test("\u2029"));
-}
diff --git a/test/mjsunit/harmony/regexp-dotall.js b/test/mjsunit/harmony/regexp-dotall.js
index eed5d26..d7b45b6 100644
--- a/test/mjsunit/harmony/regexp-dotall.js
+++ b/test/mjsunit/harmony/regexp-dotall.js
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Flags: --harmony-regexp-dotall
-
function toSlowMode(re) {
re.exec = (str) => RegExp.prototype.exec.call(re, str);
return re;
diff --git a/test/test262/testcfg.py b/test/test262/testcfg.py
index d65019d..59650f3 100644
--- a/test/test262/testcfg.py
+++ b/test/test262/testcfg.py
@@ -44,7 +44,6 @@
'object-rest': '--harmony-object-rest-spread',
'object-spread': '--harmony-object-rest-spread',
'async-iteration': '--harmony-async-iteration',
- 'regexp-dotall': '--harmony-regexp-dotall',
'regexp-named-groups': '--harmony-regexp-named-captures',
'regexp-unicode-property-escapes': '--harmony-regexp-property',
'regexp-lookbehind': '--harmony-regexp-lookbehind',
