commit | 2750f3061922448091105536f7baefe9d26eb8fa | [log] [tgz] |
---|---|---|
author | Devon Loehr <dloehr@google.com> | Fri Jul 19 16:11:13 2024 |
committer | V8 LUCI CQ <v8-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jul 26 19:10:59 2024 |
tree | dffe3245ee3b2638eed28f49c5839741170eecb0 | |
parent | 4e4d0fb962e212f33e1dcc79f987507f3bea8c33 [diff] |
Make implicit `this` capture explicit When declaring a lambda with a value-capture default [=, ...], the this pointer is implicitly captured by value as well. This results in potentially-unintuitive behavior and has been deprecated in C++20. It produces a warning in newer versions of clang (https://reviews.llvm.org/D142639). This CL makes the implicit captures explicit, preventing the warning. It does not change the compiled code at all, since it's just removing some syntactic sugar. This CL was uploaded by git cl split. R=syg@chromium.org Bug: 351004963 Change-Id: I2c0ea86d2d56ff9ec264ef4f2d7b92b1d5334ba9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5725498 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Devon Loehr <dloehr@google.com> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#95324}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://v8.dev/docs
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8
and fetch all of its dependencies. To stay up to date, run
git pull origin gclient sync
For fetching all branches, add the following into your remote configuration in .git/config
:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/* fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned at v8.dev/docs/contribute.