commit | a8268e6b3c39b1b1ca73fc8d74f0f70a9fd6ccc4 | [log] [tgz] |
---|---|---|
author | Jakob Kummerow <jkummerow@chromium.org> | Mon Jan 28 20:23:01 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jan 29 22:12:58 2019 |
tree | 46d12a774b13f0070d9cc6b65147a6355314ba2d | |
parent | f5ba52e2342b63f41d462a6040acf923d127e878 [diff] |
Fix possibly-unaligned read in TickSample::Init This is a speculative fix for issue 8744. I couldn't get it to repro locally, but the stracktrace from the failing bot run points at TickSample::Init, and according to code comments in that function the value of {regs.sp} can be "arbitrary", so we must read from that address using a method that's robust towards unalignment. Bug: v8:8744 Change-Id: I7a45cc257e0eb557715ec67d9e66e54a6f2c1867 Reviewed-on: https://chromium-review.googlesource.com/c/1440463 Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#59186}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://github.com/v8/v8/wiki
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8
and fetch all of its dependencies. To stay up to date, run
git pull origin gclient sync
For fetching all branches, add the following into your remote configuration in .git/config
:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/* fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned on the V8 wiki.