commit 30c60f38d16fde039d67198ef1af76747d5bb94e
author Marja Hölttä <marja@chromium.org> Tue Jun 16 08:04:50 2020
committer Commit Bot <commit-bot@chromium.org> Tue Jun 16 08:45:39 2020
tree 3a72079fb418b472ea185feb9e12e7685d6d43c4
parent f21291bc4120b2fbef38898aa8c98193049126b1

[bootstrapper] Remove erroneous DCHECK

The DCHECK is true in the current V8 / Chrome. However, an embedder
can create a snapshot where the object in question has dictionary
properties (by using the object as a prototype). When reading the
snapshot, in the object already has dictionary properties, and adding a
property to it won't change it.

The erroneous DCHECK was used to assert that adding a property to an
object won't turn it to dictionary mode. But now it's in the wrong
place, since this part of the code is executed after reading the
snapshot in.

The corresponding DCHECKs which are executed when setting up the objects
before snapshot creation are still valid.

Fixing the behavior wrt whether the object should turn dictionary
mode or whether it should turn back is beyond the scope of this CL.

See https://github.com/nodejs/node-v8/issues/160

Bug: v8:10479
Change-Id: Ie62c80495d4f4494eeb3a16b5bfe02305c0cac95
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246577
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68357}