commit | e37c8073342d3c5cb7d97650c391c4ec322dbce2 | [log] [tgz] |
---|---|---|
author | Nico Hartmann <nicohartmann@chromium.org> | Wed Jan 20 17:37:20 2021 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jan 29 09:07:28 2021 |
tree | 0ced41b82141abc315de8eef36a2c5a7ddc16a2a | |
parent | ebd99c6458df6aac51e9afd0ed339e75acb067cc [diff] |
Merged: Workaround for CFI bug This CL lands a workaround for a bug causing the linker to merge ExternalOneByteStringGetChar() and ExternalTwoByteStringGetChar() which leads to the generated vtable address checks failing on one of the inputs. To make the two function's machine code different (to prevent the linker from merging them), this CL adds CHECKs of the arguments to both functions. (cherry picked from commit 34e89a6ba8b5cef59e21c3892a0f09d9ca134743) Bug: chromium:1160961 Change-Id: I4a55126709caefb1f960f9fc68916f0596139a3d No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2658320 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/branch-heads/8.9@{#25} Cr-Branched-From: 16b9bbbd581c25391981aa03180b76aa60463a3e-refs/heads/8.9.255@{#1} Cr-Branched-From: d16a2a688498bd1c3e6a49edb25d8c4ca56232dc-refs/heads/master@{#72039}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://v8.dev/docs
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8
and fetch all of its dependencies. To stay up to date, run
git pull origin gclient sync
For fetching all branches, add the following into your remote configuration in .git/config
:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/* fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned at v8.dev/docs/contribute.